i#6662 public traces: allow one missing virtual_address in v2p.textproto#7174
Merged
i#6662 public traces: allow one missing virtual_address in v2p.textproto#7174
Conversation
The textproto format does not output fields with value == 0. In some cases a trace can use virtual address 0x0, so this case needs to be handled (previously we did not allow any missing fields from v2p.textproto). We do so relying on the fact that multiple missing virtual_address fields would try to map 0x0 multiple times, hence resulting in an error. Issue #6662
derekbruening
approved these changes
Jan 7, 2025
Merged
edeiana
added a commit
that referenced
this pull request
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The textproto format does not have fields with value == 0.
In some cases a trace can use virtual address 0x0, which
would result in a missing virtual_address field in
v2p.textproto.Previously we did not allow any missing fields in
v2p.textproto,so this case needs to be handled.
We do so relying on the fact that multiple missing virtual_address
fields would try to map 0x0 multiple times, resulting in an error.
We add the missing virtual_address case to the unit tests.
Issue #6662