Merged
Conversation
tcezard
approved these changes
Sep 12, 2025
| else: | ||
| pass | ||
| # Go through non-essential pragmas | ||
| for non_essential_pragma in gvf_non_essential: |
Member
There was a problem hiding this comment.
These sort of long list of if statements could be refactored to have a generic method and dioctionary that maps the start of the pragma with correct key and potentially a parser function.
I will suggest these edits in a different PR.
apriltuesday
approved these changes
Sep 12, 2025
…to header and adding a place holder for its value
…at_sample_values and format_vcf_datalines
khetherin
force-pushed
the
sample_name
branch
from
3704e11 to
15a2dd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collected sample names from the GVF header (non-essential pragmas).
For the VCF header sample names are printed in the header.
For VCF data lines each sample has had a place holder added for its value.