-
Notifications
You must be signed in to change notification settings - Fork 2
Sample name #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Sample name #4
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f5cf0b3
reading sample names from non-essential pragmas. adding sample names …
khetherin 5c8559f
removed todo
khetherin 1eb04f2
removed todo
khetherin 7ea41c7
removed print statement
khetherin 47684b7
removed new lines
khetherin ea48a5a
added new functions populate_sample_formats and format_sample_values
khetherin 531781d
added tests for generate_vcf_header_line populate_sample_formats for…
khetherin b3de500
simplified test input
khetherin 715a733
added docstring
khetherin 08ffe60
added test for format_sample_values
khetherin f7b7034
print out unknown pragmas
khetherin 221d073
added newline
khetherin 15a2dd0
added sample names to the header
khetherin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These sort of long list of if statements could be refactored to have a generic method and dioctionary that maps the start of the pragma with correct key and potentially a parser function.
I will suggest these edits in a different PR.