Skip to content

Conversation

@JBludau
Copy link
Contributor

@JBludau JBludau commented Nov 12, 2025

I just think this makes it more convenient for devs if working on a machine that does not have it installed

Copy link
Collaborator

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current CMake minimum required version is quite old (3.16):

cmake_minimum_required(VERSION 3.16)

If you bump it to something more recent (>=3.25) you could achieve the same thing w/o the if-else branch form a single FetchContent command.

Co-authored-by: Sam Reeve <[email protected]>
@JBludau
Copy link
Contributor Author

JBludau commented Nov 21, 2025

@streeve what do you think of bumping the cmake version? But it might create problems for our downstream users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants