ctsm5.4.026: Transfer biophysical variables for output with FATES dimensions#3760
ctsm5.4.026: Transfer biophysical variables for output with FATES dimensions#3760glemieux wants to merge 8 commits intoESCOMP:masterfrom
Conversation
github-project-automation
bot
moved this to Finding Reviewers
in FATES Pull Request Planning and Status
|
Fates regression testing of NGEET/fates#1536 is complete and B4B. Aside from updating the Changelog and the fates tag and commit, this is good to review. |
glemieux
moved this from Finding Reviewers
to Under Review
in FATES Pull Request Planning and Status
Change to using the ifx compiler and some more fixes Updates ccs_config to 1.0.75 which has the new ifx compiler in use for derecho_intel, as well as updating to using ESMF8.9.0. This exposed problems in the code on two fronts when running with DEBUG mode: Reliance on short-circuiting in if statements Problems with NaN's, in datasets especially _FillValue For the former, we changed code to break up if statements so this would work. And with the latter we point to new datasets with the NaN's handled. mosart and cdeps code also had short-circuiting problems. @samsrabin created a script to examine all of the files in namelist_defaults_ctsm.xml and in the testmod directories to check if there were problems with NaN's in _FillValues. The modified files here all were the result of the first pass of that script. The new files all have a ".no_nan_fill.nc" ending on them. Includes updating submodules: ccs_config, cdeps, mosart
|
Regression testing This might be related to #3797: This might be related to #3617: Note that I was seeing an issue with Results: |
Resubmitting cleared this particular unexpected failure. |
ekluzek
added
the
next
|
It looks like this is maybe ready to come to master? |
|
@ekluzek it should be; I'll deal with the merge conflicts and update the log. Where does this fall in the queue? |
Update derecho_intel again and some fixes for it Update to ccs_config1.0.77 with derecho_intel updates to intel/2024.3.2. And a two line fix to a continuation line in the middle of a string, so that it will build. Note, there are several mpi-serial Bgc cases that now fail on derecho_intel see details below. Also update the parameter files to ones that have some new fields on it that will be moved from namelist to the parameter file in a future b4b-dev PR. Improve the logging about the ch4finundation stream. Some of this seemed to be important in order to be able to change ch4finundationmapalo away from bilinear. Remove a bunch of tests in the expected fail files that have been working now. Add a few more newly failing tests.
We have one known answer changing tag that isn't ready that will need to come in. So there really isn't much of a queue right now. It looks like there might be a couple things ready for FATES and they might as well come in if they are ready. I'll make sure this is in upcoming tags. |
ekluzek
changed the title
glemieux
moved this from Under Review
to Final Testing
in FATES Pull Request Planning and Status
3 participants
Description of changes
This pull request updates the high frequency wrapper procedure in the interface to pass biophysical CLM variables to be output along FATES dimensions. The FATES land use x pft dimension is also added to the history module.
This pull request integration needs to be coordinated with NGEET/fates#1536.
Specific notes
Contributors other than yourself, if any: @ckoven
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)?
Any User Interface Changes (namelist or namelist defaults changes)?
Does this create a need to change or add documentation? Did you do so?
Testing performed, if any:
(List what testing you did to show your changes worked as expected)
(This can be manual testing or running of the different test suites)
(Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide)
(aux_clm on derecho for intel/gnu and izumi for intel/gnu/nag/nvhpc is the standard for tags on master)
NOTE: Be sure to check your coding style against the standard
(https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines) and review
the list of common problems to watch out for
(https://github.com/ESCOMP/CTSM/wiki/List-of-common-problems).