Skip to content

Landuse history superPR (#1407 + #1535)#1536

Open
glemieux wants to merge 13 commits intoNGEET:mainfrom
glemieux:superpr-1407-1535
Open

Landuse history superPR (#1407 + #1535)#1536
glemieux wants to merge 13 commits intoNGEET:mainfrom
glemieux:superpr-1407-1535

Conversation

@glemieux
Copy link
Contributor

@glemieux glemieux commented Feb 17, 2026

Description:

This pull request combines #1407 and #1535. The PRs are combined together as they both require API updates. This PR should should be integrated with ESCOMP/CTSM#3760 and E3SM-Project/E3SM#7783.

Note that ESCOMP/CTSM#3760 includes updates to work with both #1407 and #1535. E3SM-Project/E3SM#7783 only includes updates for #1535 as the updates for #1407 have already been integrated into e3sm master with E3SM-Project/E3SM@587932c (via E3SM-Project/E3SM#7231).

Collaborators:

Expectation of Answer Changes:

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided
  • FATES-CLM6 Code Freeze: satellite phenology regression tests are b4b

If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@glemieux
Copy link
Contributor Author

Regression testing on derecho against fates-sci.1.90.2_api.43.1.0-ctsm5.4.019

@glemieux
Copy link
Contributor Author

Regression testing against fates-sci.1.90.2_api.43.1.0-ctsm5.4.019 are B4B for all expected results. As expected we do see FIELDLIST differences on applicable tests.

Results: /glade/u/home/glemieux/scratch/ctsm-tests/tests_pr1536-pr3760-fates

Note that I tested the LUH2 testmods individually after realizing I should add the new variables to the LUH2 testmod variants in CLM. Results are B4B aside from the expected FIELDLIST diffs:

/glade/u/home/glemieux/scratch/ctsm-tests/tests_pr3760-pr1536-luh2-addnewvars
/glade/u/home/glemieux/scratch/ctsm-tests/tests_pr3760-pr1536-luh2-harvarea
/glade/u/home/glemieux/scratch/ctsm-tests/tests_pr3760-pr1536-luh2-harvmass

@glemieux glemieux moved this from Finding Reviewers to Final Testing in FATES Pull Request Planning and Status Feb 24, 2026
ckoven and others added 3 commits March 5, 2026 09:44
@glemieux
Copy link
Contributor Author

glemieux commented Mar 9, 2026

Regression testing on derecho and perlmutter against baseline are B4B for all expected tests, with expected FIELDLIST diffs only.

perlmutter: /global/homes/g/glemieux/scratch/e3sm-tests/pr7783-pr1536-fates-2.fates.pm-cpu..Ef9a94c623e-F6de99156f
derecho: /glade/u/home/glemieux/scratch/ctsm-tests/tests_pr1536-pr3760-fates-2

Regression testing the e3sm and ctsm side pull requests is underway.

@glemieux glemieux moved this from Final Testing to Ready to Integrate in FATES Pull Request Planning and Status Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready to Integrate

Development

Successfully merging this pull request may close these issues.

3 participants