Skip to content

Conversation

@bouweandela
Copy link
Member

@bouweandela bouweandela commented Nov 30, 2025

Description

Update the tests so they work with ESMValGroup/ESMValCore#2911


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number of pull requests:

@bouweandela
Copy link
Member Author

The test are now failing due to an issue with intake-esgf. I proposed a fix here: esgf2-us/intake-esgf#160

@valeriupredoi
Copy link
Contributor

@bouweandela I propose we merge this the sooner the better - the current state of the full dev tests outside this PR is pretty miserable 😁 https://github.com/ESMValGroup/ESMValTool/actions/runs/19879042954/job/56972844345

@bouweandela
Copy link
Member Author

I'll try running the tests without using intake-esgf then.

@bouweandela bouweandela marked this pull request as ready for review December 4, 2025 09:23
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, this is clean and nice 🍺

@valeriupredoi valeriupredoi merged commit 14b2beb into main Dec 4, 2025
10 checks passed
@valeriupredoi valeriupredoi deleted the update-recipe-test branch December 4, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants