Add embedded relations #3543

lukasluecke · 2020-07-13T15:21:15Z

// There needs to be a CrudController handling the target entity, as we display the corresponding INDEX view here.
EmbedField::new('associationName');

It supports most of the functionality, including async initial load, sort, pagination, search and actions (with a custom referrer that redirects you straight back to the embed field).

Currently the "reverse" relation field is automatically removed, if it was part of the target index view (because all values would be the current detail view entity).

lukasluecke · 2020-07-13T15:24:29Z

I would like to add a way to further customize the view (e.g. change columns, different default sort, page size), but all customization options should be part of the EmbedField options, and not the target CrudController. This is currently not easily possible, but I got a solution almost ready 🙂

Edit
Waiting on #3550 (see #3551 for an example on the usage, which is quite similar to this)

lukasluecke · 2020-07-13T16:12:21Z

Filters are not yet working correctly, their code is even more complicated to make "reusable". I might end up just having to extract all these "inline" scripts to proper functions that get called in any view where they are required, but that will be a bigger change than what I originally intended (and I might do that separately, before finishing up this PR).

Edit
I got the filters working with a single embed on the page - will try to make it a bit more flexible next..

seb-jean · 2020-07-14T19:23:52Z

Should we add an item create button? (Action::NEW)

lukasluecke · 2020-07-14T19:54:08Z

@seb-jean I‘m not sure yet how exactly I want to handle Actions in general here - maybe something like #3519, and by default render the actions defined for the index view (which in most cases is NEW).

My end goal is a kind of fully integrated experience, which probably will involve AJAX modals for create (and possibly edit), amongst other things - but I will try to get the basic functionality in before that 🙂

seb-jean · 2020-07-14T20:01:16Z

Okay, great :). I wish you good luck @lukasluecke.

This PR was merged into the 3.0.x-dev branch. Discussion ---------- Extract ControllerFactory service This is a pre-requisite for EasyCorp#3476 (MR EasyCorp#3551) and EasyCorp#3352 (see EasyCorp#3543 (comment) for details). Also deduplicated a bit of the shared logic between CrudController and DashboardController creation. Commits ------- ed63197 Extract ControllerFactory service

WeTurkstra · 2020-09-11T12:20:16Z

Can this pr be merged into the master?

ghost · 2020-09-24T10:47:04Z

I hope this feature will be merged soon 💯

sharkFace146 · 2020-11-13T14:36:55Z

Wow this feature is exactly what i want 😍.
Hope it will be merged soon 🚀.

bfavrel · 2020-11-16T19:30:36Z

Thanks for this very useful feature ! Hope it will be merged soon !
I've tested it and I've detected 2 issues :

Filter button doesn't work. It's open a new page with the filters fields inside
BooleanField that appears in table, cannot be updated (enable or disable). It seems to miss an ajax action to update the entity.

bfavrel

This code enable custom switches for BooleanField in list.

bfavrel · 2020-11-16T22:05:17Z

src/Resources/views/crud/field/embed.html.twig

+                    if(searchQuery) {
+                        $(embedContent).find('table tbody td:not(.actions)').highlight($.merge([searchQuery], searchQuery.split(' ')));
+                    }
+


Suggested change

// custom switches

const customSwitches = document.querySelectorAll('td.field-boolean .custom-control.custom-switch input[type="checkbox"]');

for (i = 0; i < customSwitches.length; i++) {

customSwitches[i].addEventListener('change', function () {

const customSwitch = this;

const newValue = this.checked;

const oldValue = !newValue;

const fieldName = this.closest('.custom-switch').dataset.fieldname;

const target = "{{ ea_url()

.unset('entityId')

.unset('referrer')

.unset('menuIndex')

.unset('submenuIndex')

.setCrudId(crud_id)

.setAction('edit')|raw }}";

const toggleUrl = target

+ "&entityId=" + this.closest('[data-id]').dataset.id

+ "&fieldName=" + fieldName

+ "&newValue=" + newValue.toString();

let toggleRequest = $.ajax({ type: "GET", url: toggleUrl, data: {} });

toggleRequest.done(function(result) {});

toggleRequest.fail(function() {

// in case of error, restore the original value and disable the toggle

customSwitch.checked = oldValue;

customSwitch.disabled = true;

customSwitch.closest('.custom-switch').classList.add('disabled');

});

});

}

lukasluecke · 2020-11-17T11:01:41Z

Thanks for your feedback and contribution. I'm currently very busy in another project which does not use EasyAdmin, but hope that I can find some time to finish this PR and some others around christmas time 🤞

If anyone else wants to pick this up in the meantime feel free to take this over in a new PR as well 🙂

finnef · 2021-01-06T14:39:05Z

Hmm patch needs reroll for EA 3.2 it seems.

fix rebase issue

Mancusoj · 2022-10-12T13:45:08Z

I would like to add a list of this type for a collection, does it work in easyadmin 4?

wontroba666 · 2023-02-17T10:41:38Z

does it work in easyadmin 4? this is great

User12312412412 · 2023-12-19T13:49:52Z

Can this please be implemented? To provide you with a use case for this it's when you need to display a complex entity with one to many relationships in a tab.

Say a Subscription being the primary entity and so you create a tab that has Members (OneToMany).
The usecase here is that we're able to display the OneToMany relationship as a paginated and filterable table.

Some subscription records for example have 1000s of records and doing CollectionField::new('members') simple does not work due to the volume of fields it has to display.

msphn · 2024-02-21T14:13:10Z

I'd be willing to invest into this and port this for EA 4 but I have concerns about the acceptance of PRs in general atm. Would that change get accepted or would it be better to create a bundle containing this feature?

NicoHaase · 2024-03-08T14:16:14Z

Are there any news on this topic?

psihius · 2024-07-15T06:34:56Z

I can confirm that this one does not work on EA4 and needs updates quite a bit.
I've adapted for my project for some of the functionality to work, but there have been major changes in how the system works so the grid needs to be split into blocks and probably work via horizontal reuse instead of pure inheritance or just need to maintain 2 grid templates - one regular and one for embedded.
This needs buy-in from stakeholders, because while not too big, still a sizeable addition to the amount of code to maintain.
@javiereguiluz and please tag whoever else needs to be in the loop - is this something that would be accepted? Or should I just maintain my own patch and not bother submitting upstream?

psihius · 2024-07-25T10:01:26Z

I've made a new PR because changes to this for 4.x are extensive and I had to redo some things, there's a lot more work to be done, so I do not see a point keeping this one open any more. 4.x series has a lot more complicated interactions and way it is doing things.

javiereguiluz · 2024-07-25T18:06:25Z

Let's close this in favor of #6384 where @psihius is trying to implement this feature in the 4.x branch 💪

javiereguiluz added the feature label Jul 13, 2020

javiereguiluz added this to the 3.x milestone Jul 13, 2020

This was referenced Jul 13, 2020

[3.x] AJAX search #3549

Closed

Extract ControllerFactory service #3550

Closed

This was referenced Jul 23, 2020

Implement other entity on page detail #3609

Closed

[3.x] [RFC] Static, cached, identifiable contexts #3623

Closed

quentint mentioned this pull request Oct 1, 2020

Ability to include entity table datagrid on non-CRUD page (eg. dashboard index) #3847

Closed

creiner mentioned this pull request Nov 13, 2020

how to show a collection as a datatable #3950

Closed

bfavrel suggested changes Nov 16, 2020

View reviewed changes

creiner mentioned this pull request Dec 3, 2020

A new theme and UI kit for EasyAdmin #4011

Closed

Add embedded relations

1c030e2

rugbymauri force-pushed the embedded-relations branch from 2c8d296 to 1c030e2 Compare January 29, 2021 17:11

rugbymauri added 3 commits January 29, 2021 19:32

refactor use AdminUrlGenerator::setController

2d71acd

fix rebase issue

check if filterProperty is in the fields before removing

87fd673

ad controllerFqcn to the embedContext

3695448

psihius mentioned this pull request Jul 25, 2024

[WIP] [RFC] Embedded crud in forms #6384

Draft

javiereguiluz closed this Jul 25, 2024

+// custom switches
+                    const customSwitches = document.querySelectorAll('td.field-boolean .custom-control.custom-switch input[type="checkbox"]');
+                    for (i = 0; i < customSwitches.length; i++) {
+                        customSwitches[i].addEventListener('change', function () {
+                            const customSwitch = this;
+                            const newValue = this.checked;
+                            const oldValue = !newValue;
+                            const fieldName = this.closest('.custom-switch').dataset.fieldname;
+                            const target = "{{ ea_url()
+                                .unset('entityId')
+                                .unset('referrer')
+                                .unset('menuIndex')
+                                .unset('submenuIndex')
+                                .setCrudId(crud_id)
+                                .setAction('edit')|raw }}";
+                            const toggleUrl = target
+                                + "&entityId=" + this.closest('[data-id]').dataset.id
+                                + "&fieldName=" + fieldName
+                                + "&newValue=" + newValue.toString();
+                            let toggleRequest = $.ajax({ type: "GET", url: toggleUrl, data: {} });
+                            toggleRequest.done(function(result) {});
+                            toggleRequest.fail(function() {
+                                // in case of error, restore the original value and disable the toggle
+                                customSwitch.checked = oldValue;
+                                customSwitch.disabled = true;
+                                customSwitch.closest('.custom-switch').classList.add('disabled');
+                            });
+                        });
+                    }

Uh oh!

Add embedded relations #3543

Add embedded relations #3543

Uh oh!

Conversation

lukasluecke commented Jul 13, 2020

Uh oh!

lukasluecke commented Jul 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lukasluecke commented Jul 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seb-jean commented Jul 14, 2020

Uh oh!

lukasluecke commented Jul 14, 2020

Uh oh!

seb-jean commented Jul 14, 2020

Uh oh!

WeTurkstra commented Sep 11, 2020

Uh oh!

ghost commented Sep 24, 2020

Uh oh!

sharkFace146 commented Nov 13, 2020

Uh oh!

bfavrel commented Nov 16, 2020

Uh oh!

bfavrel left a comment

Choose a reason for hiding this comment

Uh oh!

bfavrel Nov 16, 2020

Choose a reason for hiding this comment

Uh oh!

lukasluecke commented Nov 17, 2020

Uh oh!

finnef commented Jan 6, 2021

Uh oh!

Mancusoj commented Oct 12, 2022

Uh oh!

wontroba666 commented Feb 17, 2023

Uh oh!

User12312412412 commented Dec 19, 2023

Uh oh!

msphn commented Feb 21, 2024

Uh oh!

NicoHaase commented Mar 8, 2024

Uh oh!

psihius commented Jul 15, 2024

Uh oh!

psihius commented Jul 25, 2024

Uh oh!

javiereguiluz commented Jul 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

lukasluecke commented Jul 13, 2020 •

edited

Loading

lukasluecke commented Jul 13, 2020 •

edited

Loading