Extract ControllerFactory service #3550
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasluecke
commented
Jul 13, 2020
| return $this->getController(DashboardControllerInterface::class, $dashboardControllerFqcn, 'index', $request); | ||
| } | ||
|
|
||
| private function getCrudController(?string $crudControllerFqcn, ?string $crudAction, Request $request): ?CrudControllerInterface |
Contributor
Author
There was a problem hiding this comment.
I've noticed that from AdminContext you can only get the $crudControllerFqcn, not the $crudId - so maybe this one should be public so you don't need to always also inject the CrudControllerRegistry. Or make the $crudId available in AdminContext.
This was referenced Jul 13, 2020
Closed
Collaborator
|
Thanks Lukas. While merging I changed the name of |
javiereguiluz
added a commit
to javiereguiluz/EasyAdminBundle
that referenced
this pull request
Jul 15, 2020
This PR was merged into the 3.0.x-dev branch. Discussion ---------- Extract ControllerFactory service This is a pre-requisite for EasyCorp#3476 (MR EasyCorp#3551) and EasyCorp#3352 (see EasyCorp#3543 (comment) for details). Also deduplicated a bit of the shared logic between CrudController and DashboardController creation. Commits ------- ed63197 Extract ControllerFactory service
javiereguiluz
added a commit
that referenced
this pull request
Nov 11, 2020
…tocomplete) (lukasluecke) This PR was squashed before being merged into the 3.0.x-dev branch. Discussion ---------- Add option to modify query of AssociationField (with autocomplete) Resolves #3476. Depends on #3550. Works the same for "default" and autocomplete fields. ```php AssociationField::new('property') ->autocomplete() // optional ->modifyQuery(fn(QueryBuilder $queryBuilder) => $queryBuilder ->where('entity.id > 20') ->orderBy('entity.field', 'DESC') ); ``` Commits ------- 4716e81 Add option to modify query of AssociationField (with autocomplete)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pre-requisite for #3476 (MR #3551) and #3352 (see #3543 (comment) for details).
Also deduplicated a bit of the shared logic between CrudController and DashboardController creation.