Skip to content

Fix compilation issue on LTS due to changes in NearestNeighbors (NN) API#77

Merged
mkborregaard merged 5 commits intoEcoJulia:mainfrom
tpoisot:tpoisot/issue76
Jan 29, 2026
Merged

Fix compilation issue on LTS due to changes in NearestNeighbors (NN) API#77
mkborregaard merged 5 commits intoEcoJulia:mainfrom
tpoisot:tpoisot/issue76

Conversation

@tpoisot
Copy link
Collaborator

@tpoisot tpoisot commented Jan 21, 2026

What the pull request does
A change in NL (always_false as an export was replaced by Returns(false) broke precompilation.

Fixes #76

This has been fixed by creating a global variable always_false = Returns(false). If NN exports always_false, this one is used instead. The later is important as previous versions of NN may not handle Returns(false). This results in no change to the package code.

Type of change

  • 🐛 Bug fix (non-breaking change which fixes an issue)

Checklist

  • The changes are tested
  • The changes do not modify the behavior of the previously existing functions
  • The Project.toml field version has been updated

@tpoisot
Copy link
Collaborator Author

tpoisot commented Jan 21, 2026

@mkborregaard I've also brought the julia github actions to their latest versions

@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.39%. Comparing base (db77779) to head (091fa10).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   88.23%   88.39%   +0.15%     
==========================================
  Files          19       19              
  Lines         476      491      +15     
==========================================
+ Hits          420      434      +14     
- Misses         56       57       +1     
Flag Coverage Δ
unittests 88.39% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tpoisot
Copy link
Collaborator Author

tpoisot commented Jan 28, 2026

@mkborregaard - just a bump, this is ready to merge afaict

@mkborregaard
Copy link
Member

Sorry, I had missed this!

@mkborregaard mkborregaard merged commit 200cd3e into EcoJulia:main Jan 29, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't compile on lts

2 participants