Skip to content

Fix compilation issue on LTS due to changes in NearestNeighbors (NN) API #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkborregaard merged 5 commits into from
Jan 29, 2026
Merged

Fix compilation issue on LTS due to changes in NearestNeighbors (NN) API #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c7266bf
fixes always_false if not present in NN
tpoisot Jan 21, 2026
387266c
Fix (handling of NN.always_false on lts)
tpoisot Jan 21, 2026
783dedc
semver: v0.1.6
tpoisot Jan 21, 2026
1315fd9
update CI to test on lts and 1
tpoisot Jan 21, 2026
091fa10
catch up on github action versions
tpoisot Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ jobs:
strategy:
matrix:
version:
- '1.9'
- 'lts'
- '1'
os:
- ubuntu-latest
- macOS-latest
Expand All @@ -26,7 +27,7 @@ jobs:
experimental: [false]
steps:
- uses: actions/checkout@v2
- uses: julia-actions/setup-julia@v1
- uses: julia-actions/setup-julia@v2
with:
version: ${{ matrix.version }}
arch: ${{ matrix.arch }}
Expand All @@ -35,7 +36,7 @@ jobs:
env:
GKSwstype: "100" # https://discourse.julialang.org/t/generation-of-documentation-fails-qt-qpa-xcb-could-not-connect-to-display/60988
- uses: julia-actions/julia-processcoverage@v1
- uses: codecov/codecov-action@v1
- uses: codecov/codecov-action@v5
with:
file: ./lcov.info
flags: unittests
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "NeutralLandscapes"
uuid = "71847384-8354-4223-ac08-659a5128069f"
authors = ["Timothée Poisot <timothee.poisot@umontreal.ca>", "Michael Krabbe Borregaard <mkborregaard@sund.ku.dk>", "Michael David Catchen <michael.catchen@mail.mcgill.ca>", "Rafael Schouten <rafaelschouten@gmail.com>", "Virgile Baudrot <virgile.baudrot@posteo.net>"]
version = "0.1.5"
version = "0.1.6"

[deps]
DataStructures = "864edb3b-99cc-5e75-8d2d-829cb0a9cfe8"
Expand Down
9 changes: 8 additions & 1 deletion src/NeutralLandscapes.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,14 @@ using StatsBase: sample, ZScoreTransform, fit, transform
using Random: rand!
using Statistics: quantile, mean
using Distributions: Normal, LogNormal, MvNormal, Categorical, pdf
using NearestNeighbors: KDTree, knn, nn, always_false, knn_point!, SVector
using NearestNeighbors: KDTree, knn, nn, knn_point!, SVector

import NearestNeighbors
always_false = Returns(false)
if isdefined(NearestNeighbors, :always_false)
global always_false = NearestNeighbors.always_false
end

using DataStructures: IntDisjointSets, union!, find_root, push!
using Base: @kwdef
using HaltonSequences: haltonvalue
Expand Down
Loading