[AA-1790] Add comprehensive Docker README.md with setup instructions for PostgreSQL and SQL Server#533
Conversation
Co-authored-by: roberthunterjr <8196647+roberthunterjr@users.noreply.github.com>
…mpose syntax Co-authored-by: roberthunterjr <8196647+roberthunterjr@users.noreply.github.com>
roberthunterjr
left a comment
There was a problem hiding this comment.
These instructions look great for a bash environment. Can we add details for a power shell environment, specifically an environment that may not include openssl? Please also add a software requirements section that list the supported OS and tools needed for certificate and encryption key generation.
…ker README Co-authored-by: roberthunterjr <8196647+roberthunterjr@users.noreply.github.com>
I've added comprehensive PowerShell support and a detailed software requirements section. The changes include: Software Requirements Section:
PowerShell Environment Support:
The documentation now fully supports environments that may not include OpenSSL by providing pure PowerShell/.NET alternatives for all certificate and key generation operations. Commit: f176303 |
| ### Command Line Environment | ||
| - **Linux/macOS**: Bash shell | ||
| - **Windows**: PowerShell, Command Prompt, or WSL2 terminal | ||
|
|
There was a problem hiding this comment.
Wow, these are very thorough instructions above! It did miss one thing though: Windows users will already have openssl if they've installed Git or WSL. No need to install a separate utility.
There was a problem hiding this comment.
Now I see that you added a comment to prompt this @roberthunterjr - not just Copilot going overboard 😉
There was a problem hiding this comment.
Good point! I've updated the Windows section to highlight Git for Windows as the primary OpenSSL option since most Windows users already have it installed. The documentation now prioritizes existing OpenSSL installations before suggesting separate downloads.
Commit: 60dfd6e
There was a problem hiding this comment.
Wow, these are very thorough instructions above! It did miss one thing though: Windows users will already have
opensslif they've installed Git or WSL. No need to install a separate utility.
@stephenfuqua Wasn't sure if this was the right assumption or not. Since this is the case do you think we should roll back adding the PS utility?
|
|
||
| # Or temporarily bypass execution policy for a single script | ||
| PowerShell -ExecutionPolicy Bypass -File .\generate-certificate.ps1 | ||
| ``` |
There was a problem hiding this comment.
Personally I wouldn't have added this much detail on running PowerShell 😆 . Maybe a little too overzealous, but I won't complain.
| docker compose -f docker-compose.yml up --build adminapp | ||
| ``` | ||
|
|
||
| The development Dockerfiles (`dev.pgsql.Dockerfile` and `dev.mssql.Dockerfile`) build the application from source rather than downloading pre-built packages. |
There was a problem hiding this comment.
Close! Not quite right. To use the dev files, one would need to modify the docker-compose.yml to refer to the other Dockerfile instead of the default pgsql.Dockerfile.
There was a problem hiding this comment.
You're absolutely right! I've corrected the development mode instructions to properly explain that the docker-compose.yml file needs to be modified to reference the dev.pgsql.Dockerfile or dev.mssql.Dockerfile instead of the default ones. The previous instructions were misleading about how to actually use the development Dockerfiles.
Commit: 60dfd6e
| API_MODE=SharedInstance | ||
| ``` | ||
|
|
||
| ### SSL Configuration |
There was a problem hiding this comment.
Is this section redundant with information up above?
There was a problem hiding this comment.
@copilot this configuration step feel redundant with the information in the Generate SSL Certificates section above. Lets either reword this SSL Configuration section to add value, or remove it if there is not enough additional value added by providing these configuration options.
There was a problem hiding this comment.
I've removed the redundant SSL certificate generation instructions from the SSL Configuration section and focused it on production/custom certificate scenarios and hostname configuration. The detailed certificate generation steps remain in the Quick Start section where they belong.
Commit: 443fd00
There was a problem hiding this comment.
I didn't expect it to generate a new PowerShell script. Looks useful.
There was a problem hiding this comment.
No impact on Windows machines.
…ctions Co-authored-by: stephenfuqua <9324390+stephenfuqua@users.noreply.github.com>
roberthunterjr
left a comment
There was a problem hiding this comment.
Looks good. Lets address the provided comments before approval
| API_MODE=SharedInstance | ||
| ``` | ||
|
|
||
| ### SSL Configuration |
There was a problem hiding this comment.
@copilot this configuration step feel redundant with the information in the Generate SSL Certificates section above. Lets either reword this SSL Configuration section to add value, or remove it if there is not enough additional value added by providing these configuration options.
…ction Co-authored-by: roberthunterjr <8196647+roberthunterjr@users.noreply.github.com>
|
@copilot rebase |
I'm unable to perform git rebase operations directly due to security limitations. The branch currently has a merge commit from main. To rebase, you would need to run |
Added a comprehensive
Docker/README.mdfile with detailed instructions for running the Ed-Fi ODS Admin App using Docker Compose in both PostgreSQL and SQL Server modes.Key Features
Complete Setup Guide
Database Engine Support
Operational Guidance
generate-certificate.shTroubleshooting & Best Practices
Technical Updates
docker composesyntax throughout (replacing deprecateddocker-compose)Documentation Quality
The documentation provides everything needed for users to successfully deploy the Admin App with Docker in either database configuration, from initial setup through production considerations.
Fixes #532.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.