[CERT-210] - CI GitHub Actions: Lint + Automated tests#58
[CERT-210] - CI GitHub Actions: Lint + Automated tests#58josephcampos-gap wants to merge 12 commits intomainfrom
Conversation
02b6685 to
da0078f
Compare
Bruno Lint ReportFiles Scanned: 278 Triggered by workflow: lint-bruno.yml |
QA Scenarios SummaryStatus: PASS
|
|
@josephcampos-gap I did not take a close look... but very happy to see you adding these files! Thank you for applying this good engineering practice. The Ed-Fi Alliance has developed some requirements for safe use of Actions; please read https://docs.ed-fi.org/community/sdlc/continuous-integration/guidelines-for-use-of-github-actions @jpardogrowthaccelerationpartners or @DavidJGapCR can be good resources for you in updating these workflows to match our requirements. |
stephenfuqua
left a comment
There was a problem hiding this comment.
Please add a workflow for running the Ed-Fi actions scanner.
24c45d6 to
d61bd1c
Compare
d61bd1c to
f1915ea
Compare
QA Scenarios SummaryStatus: FAIL
|
Bruno Lint ReportFiles Scanned: 334 Triggered by workflow: lint-bruno.yml |
QA Scenarios SummaryStatus: PASS
|
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Bruno Lint ReportFiles Scanned: 334 Triggered by workflow: lint-bruno.yml |
QA Scenarios SummaryStatus: PASS
|
This pull request introduces several improvements to our GitHub Actions workflows and Bruno test suite. The main updates include adding a comprehensive guide for testing GitHub Actions locally, creating a new QA Scenarios workflow, and enhancing consistency and maintainability in Bruno test files. Additionally, there are important adjustments to workflow triggers and permissions.
Key changes:
GitHub Actions Workflows
.github/workflows/qa-scenarios.ymlto automate running QA scenarios on pull requests and pushes, aggregate results, upload artifacts, and comment summaries on PRs. It supports manual dispatch with environment and detail options.bruno/subdirectory), and changed permissions to allow PR commenting. The workflow now explicitly supplies the GitHub token for comment steps. [1] [2].github/TESTING_ACTIONS_LOCALLY.md, a detailed guide on usingactto test workflows locally, troubleshoot common issues, and validate the Bruno lint workflow.Bruno Test Suite Consistency
.brufiles (e.g., Staff and Grade associations) with placeholder variables (e.g.,[ENTER_SCHOOL_ID]) to improve reusability and clarity. [1] [2] [3] [4] [5] [6] [7]folder.bruand simplified a descriptor encoding script in a Student Program association test. [1] [2]These changes collectively improve workflow automation, developer experience, and the maintainability of our test suite.