Skip to content

[CERT-210] - CI GitHub Actions: Lint + Automated tests#58

Closed
josephcampos-gap wants to merge 12 commits intomainfrom
github-actions-qa-ci
Closed

[CERT-210] - CI GitHub Actions: Lint + Automated tests#58
josephcampos-gap wants to merge 12 commits intomainfrom
github-actions-qa-ci

Conversation

@josephcampos-gap
Copy link
Contributor

@josephcampos-gap josephcampos-gap commented Oct 29, 2025

This pull request introduces several improvements to our GitHub Actions workflows and Bruno test suite. The main updates include adding a comprehensive guide for testing GitHub Actions locally, creating a new QA Scenarios workflow, and enhancing consistency and maintainability in Bruno test files. Additionally, there are important adjustments to workflow triggers and permissions.

Key changes:

GitHub Actions Workflows

  • New QA Scenarios Workflow:
    • Introduced .github/workflows/qa-scenarios.yml to automate running QA scenarios on pull requests and pushes, aggregate results, upload artifacts, and comment summaries on PRs. It supports manual dispatch with environment and detail options.
  • Bruno Lint Workflow Improvements:
    • Updated workflow file paths and triggers to match the new project structure (bruno/ subdirectory), and changed permissions to allow PR commenting. The workflow now explicitly supplies the GitHub token for comment steps. [1] [2]
  • Local Testing Documentation:
    • Added .github/TESTING_ACTIONS_LOCALLY.md, a detailed guide on using act to test workflows locally, troubleshoot common issues, and validate the Bruno lint workflow.

Bruno Test Suite Consistency

  • Parameterization of Test Data:
    • Replaced hardcoded IDs and values in several .bru files (e.g., Staff and Grade associations) with placeholder variables (e.g., [ENTER_SCHOOL_ID]) to improve reusability and clarity. [1] [2] [3] [4] [5] [6] [7]
  • Minor Documentation and Assertion Updates:
    • Fixed table formatting in folder.bru and simplified a descriptor encoding script in a Student Program association test. [1] [2]

These changes collectively improve workflow automation, developer experience, and the maintainability of our test suite.

@josephcampos-gap josephcampos-gap changed the title [GitHub Actions] - QA Continuous Integration [CERT-210] - GitHub Actions: QA Continuous Integration Oct 30, 2025
@Ed-Fi-Alliance-OSS Ed-Fi-Alliance-OSS deleted a comment from github-actions bot Oct 30, 2025
@Ed-Fi-Alliance-OSS Ed-Fi-Alliance-OSS deleted a comment from github-actions bot Oct 30, 2025
@Ed-Fi-Alliance-OSS Ed-Fi-Alliance-OSS deleted a comment from github-actions bot Oct 30, 2025
@Ed-Fi-Alliance-OSS Ed-Fi-Alliance-OSS deleted a comment from github-actions bot Oct 30, 2025
@github-actions
Copy link

Bruno Lint Report

Files Scanned: 278
Problems: 0 (Errors: 0, Warnings: 0)
✅ No blocking errors.

Triggered by workflow: lint-bruno.yml

@github-actions
Copy link

QA Scenarios Summary

Status: PASS
Entities Processed: 1
Assertions: Passed 19, Failed 0, Total 19

Entity Passed Failed Total
BellSchedules 19 0 19

@Ed-Fi-Alliance-OSS Ed-Fi-Alliance-OSS deleted a comment from github-actions bot Oct 30, 2025
@Ed-Fi-Alliance-OSS Ed-Fi-Alliance-OSS deleted a comment from github-actions bot Oct 30, 2025
@stephenfuqua
Copy link
Contributor

@josephcampos-gap I did not take a close look... but very happy to see you adding these files! Thank you for applying this good engineering practice.

The Ed-Fi Alliance has developed some requirements for safe use of Actions; please read https://docs.ed-fi.org/community/sdlc/continuous-integration/guidelines-for-use-of-github-actions

@jpardogrowthaccelerationpartners or @DavidJGapCR can be good resources for you in updating these workflows to match our requirements.

Copy link
Contributor

@stephenfuqua stephenfuqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link

QA Scenarios Summary

Status: FAIL
Entities Processed: 1
Assertions: Passed 18, Failed 1, Total 19

Entity Passed Failed Total
BellSchedules 18 1 19

@josephcampos-gap josephcampos-gap changed the title [CERT-210] - GitHub Actions: QA Continuous Integration [CERT-210] - CI GitHub Actions: Lint + Automated tests Nov 28, 2025
@github-actions
Copy link

Bruno Lint Report

Files Scanned: 334
Problems: 0 (Errors: 0, Warnings: 0)
✅ No blocking errors.

Triggered by workflow: lint-bruno.yml

@github-actions
Copy link

QA Scenarios Summary

Status: PASS
Entities Processed: 1
Assertions: Passed 19, Failed 0, Total 19

Entity Passed Failed Total
BellSchedules 19 0 19

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@github-actions
Copy link

Bruno Lint Report

Files Scanned: 334
Problems: 0 (Errors: 0, Warnings: 0)
✅ No blocking errors.

Triggered by workflow: lint-bruno.yml

@github-actions
Copy link

QA Scenarios Summary

Status: PASS
Entities Processed: 1
Assertions: Passed 19, Failed 0, Total 19

Entity Passed Failed Total
BellSchedules 19 0 19

@josephcampos-gap josephcampos-gap deleted the github-actions-qa-ci branch December 2, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants