Jon/wallet-details-header

[Jon-edge]

For the TransactionList, keep the same title so the user knows which wallet the transactions are for.

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

• Yes
• No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

• Tested on iOS device
• Tested on Android device
• Tested on small-screen device (iPod Touch)
• Tested on large-screen device (tablet)

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1208077272222816

[swansontec]

Delete the sceneTitle param, and put the string formatting in fromParams:

const account = useSelector(state => state.core.account)
const wallet = account.currencyWallets[walletId]
return sprintf(lstrings.create_wallet_account_metadata_name, wallet?.currencyInfo.displayName)

Or, better yet, export a WalletDetailsTitle component from WalletDetailsScene.tsx:

export const WalletDetailsTitle = () => {
  const route = useRoute<RouteProp<'walletDetails'>>()
  const account = useSelector(state => state.core.account)
  const wallet = account.currencyWallets[walletId]
  const title = sprintf(lstrings.create_wallet_account_metadata_name, wallet?.currencyInfo.displayName)
  return <HeaderTitle title={title} />
}

Then in Main.tsx, it can just be:

options={{ headerTitle: WalletDetailsTitle })

Oh, one more thing: The lstrings.create_wallet_account_metadata_name should be called lstrings.network_title_1s or something like that.

[Jon-edge]

Regarding the string name, yes, it should be that, but this is an old string. Since it's old and has translations already, we can't change the key or we reset the translations.

[swansontec]

Ok, that makes sense. We really need to figure out how to rename strings in Crowdin.

[swansontec]

So waletName isn't actually used anywhere. Please delete it, so the params are literally just walletId and tokenId...

It turns out that the countryCode route prop isn't really used either. Or, more specifically, there is only one place that actually provides it to WalletListScene, and that just does:

 const { countryCode } = await getFirstOpenInfo()
 navigation.navigate('walletDetails', { walletId, tokenId, countryCode })

The WalletDetailsScene doesn't use countryCode either. The only thing it does is pass countryCode to InfoCardCarousel and BuyCrypto, both of which will be buggy (showing wrong cards or wrong strings) if countryCode is undefined.

This means we should just refactor InfoCardCarousel and BuyCrypto to get their own country code:

const [ firstOpenInfo ] = useAsyncValue(async () => await getFirstOpenInfo())
const { countryCode } =  firstOpenInfo ?? {}

And then we can delete it the WalletDetailsScene courntryCode param.

[Jon-edge]

I vaguely remember there was some reason we passed countryCode around instead of calling for it in the component but maybe it's no longer relevant...

[swansontec]

Thanks. But now that this is here, the walletName and countryCode route props are unused. For the the TransactionListScene, the route props should just be walletId, tokenId, and searchText.