Fix react-native-store-review
#5908
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 99b06a4070
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| -#import "RNStoreReview-Swift.h" | ||
| +#import <RNStoreReview/RNStoreReview-Swift.h> |
There was a problem hiding this comment.
When RCT_NEW_ARCH_ENABLED=1, RNStoreReview.podspec later assigns s.pod_target_xcconfig inside the new-architecture guard, which overwrites the new DEFINES_MODULE/SWIFT_VERSION hash added here. That means the module isn’t defined in new-arch builds, but the Objective‑C++ file now uses module-style import (<RNStoreReview/RNStoreReview-Swift.h>), so the Swift header won’t be found and the build can fail. Consider merging the hashes or adding those keys to the new-arch s.pod_target_xcconfig block so the module import works in both architectures.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Feta builds work so this should be fine?
Package is not being maintained as of 2023. A forked branch and PR addresses iOS 18+ support: oblador/react-native-store-review@575f492 - The dependency now points to the above fork/SHA - Patched to add the missing Swifth module configuration to the podspec, and to import using angle brackets in the swift code.
Jon-edge
force-pushed
the
jon/fix/ios-store-review
branch
from
99b06a4 to
4fc90ab
Compare
Package is not being maintained as of 2023. A forked branch and PR addresses iOS 18+ support: oblador/react-native-store-review@575f492
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Resolves in‑app review issues on iOS 18+ by updating and patching the review module.
react-native-store-reviewto a forked commit with iOS 18+ support and updateyarn.lock/Podfile.lockpatch-package) to setDEFINES_MODULEandSWIFT_VERSIONin podspec and change iOS import to module formCHANGELOG.mdwith “fixed: In-app review for iOS 18+”Written by Cursor Bugbot for commit 4fc90ab. This will update automatically on new commits. Configure here.