Skip to content

Fix react-native-store-review #5908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jon-edge merged 1 commit into from
Jan 17, 2026
+32 −5
Merged

Fix react-native-store-review #5908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
- fixed: ramps: Various Infinite UI/UX issues
- fixed: Search keyboard not dismissing when submitting search
- fixed: Auto-correct not disabled for search input
- fixed: In-app review for iOS 18+

## 4.41.1 (2025-12-29)

Expand Down
2 changes: 1 addition & 1 deletion ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3475,7 +3475,7 @@ SPEC CHECKSUMS:
RNSentry: 19b4ee2a31886bcc5a64698a27cf8495cb8f5d17
RNShare: 6300b941668273d502ecee9122cade0d5ea966bd
RNSound: cfeaf6c6a734303c887e04b946cbb7e294bff123
RNStoreReview: 8b47d208282c23296d2466a488a8d9ca1979d79b
RNStoreReview: b3cb7df1405d56afd51301ada4660f6c9b970055
RNSVG: ca807495c5219c05c747254200b89a4e3078db31
RNVectorIcons: f1bc9e04b6f67ec09ea54e6f092e75a9e205c1d7
RNWorklets: b1faafefb82d9f29c4018404a0fb33974b494a7b
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@
"react-native-securerandom": "^1.0.1",
"react-native-share": "^12.0.11",
"react-native-sound": "^0.12.0",
"react-native-store-review": "^0.4.3",
"react-native-store-review": "https://github.com/dylancom/react-native-store-review#575f49229de2439095205b3cd17babea31972c95",
"react-native-svg": "^15.12.1",
"react-native-vector-icons": "^10.1.0",
"react-native-vision-camera": "^4.7.2",
Expand Down
27 changes: 27 additions & 0 deletions patches/react-native-store-review+0.4.3.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
diff --git a/node_modules/react-native-store-review/RNStoreReview.podspec b/node_modules/react-native-store-review/RNStoreReview.podspec
index 1234567..abcdefg 100644
--- a/node_modules/react-native-store-review/RNStoreReview.podspec
+++ b/node_modules/react-native-store-review/RNStoreReview.podspec
@@ -14,6 +14,10 @@ Pod::Spec.new do |s|
s.preserve_paths = "**/*.js"
s.ios.framework = 'StoreKit'
s.requires_arc = true
+ s.pod_target_xcconfig = {
+ 'DEFINES_MODULE' => 'YES',
+ 'SWIFT_VERSION' => '5.0'
+ }

s.dependency "React-Core"

diff --git a/node_modules/react-native-store-review/ios/RNStoreReview.mm b/node_modules/react-native-store-review/ios/RNStoreReview.mm
index 2345678..bcdefgh 100644
--- a/node_modules/react-native-store-review/ios/RNStoreReview.mm
+++ b/node_modules/react-native-store-review/ios/RNStoreReview.mm
@@ -1,6 +1,6 @@
#import "RNStoreReview.h"

-#import "RNStoreReview-Swift.h"
+#import <RNStoreReview/RNStoreReview-Swift.h>
Comment on lines +23 to +24
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Merge pod_target_xcconfig for new arch

When RCT_NEW_ARCH_ENABLED=1, RNStoreReview.podspec later assigns s.pod_target_xcconfig inside the new-architecture guard, which overwrites the new DEFINES_MODULE/SWIFT_VERSION hash added here. That means the module isn’t defined in new-arch builds, but the Objective‑C++ file now uses module-style import (<RNStoreReview/RNStoreReview-Swift.h>), so the Swift header won’t be found and the build can fail. Consider merging the hashes or adding those keys to the new-arch s.pod_target_xcconfig block so the module import works in both architectures.

Useful? React with 👍 / 👎.

Copy link
Collaborator Author

@Jon-edge Jon-edge Jan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feta builds work so this should be fine?


@implementation RNStoreReview

5 changes: 2 additions & 3 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16237,10 +16237,9 @@ react-native-sound@^0.12.0:
resolved "https://registry.yarnpkg.com/react-native-sound/-/react-native-sound-0.12.0.tgz#c1502e7760efa7ca06c38b8ae0435518eae33ef8"
integrity sha512-uOtM/PJ8+xmuXwgS2WMYEcokE/oFE8MV6glZHmB5RYHZ+yzD/0Z7cDL+QJpetTYBbEFOirfcE42o6YfPMJfJfg==

react-native-store-review@^0.4.3:
"react-native-store-review@https://github.com/dylancom/react-native-store-review#575f49229de2439095205b3cd17babea31972c95":
version "0.4.3"
resolved "https://registry.yarnpkg.com/react-native-store-review/-/react-native-store-review-0.4.3.tgz#a524374b1a897b1de1b05d6257640296f1693e3c"
integrity sha512-RSQ6vx2j4p41GwTqNv2VV7yold62j5qDbGEBAjFi6gkXMrMpxFMg+82FPjbh6012tqv6Ebzwfqw6S4m4d7sddw==
resolved "https://github.com/dylancom/react-native-store-review#575f49229de2439095205b3cd17babea31972c95"

react-native-svg-transformer@^1.5.1:
version "1.5.1"
Expand Down
Loading