Ensure client is defined when catching error

[sidpremkumar]

Type

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update

Description

We have been seeing errors:

2025-12-31 04:02:27.243 | at <anonymous> (/app/node_modules/pg-pool/index.js:216:18)
2025-12-31 04:02:27.243 | at <anonymous> (/app/node_modules/@effect/sql-pg/dist/esm/PgClient.js:232:7)
2025-12-31 04:02:27.243 | TypeError: undefined is not an object (evaluating 'client.on')
2025-12-31 04:02:27.243 | ^
2025-12-31 04:02:27.243 | 232 | client.on("error", onError);
2025-12-31 04:02:27.243 | 231 | }
2025-12-31 04:02:27.243 | 230 | cause = cause_;
2025-12-31 04:02:27.243 | 229 | function onError(cause_) {
2025-12-31 04:02:27.243 | 228 | }

We have tried modifying and guarding better on our application code - but this issue persisted. We think it's coming from here, specifically the client! assertion that causes the entire app to crash and restart our application.

Believe this can be fixed by making sure the client exists before calling on error.

This seems to be known:
Ref: brianc/node-postgres#2492 (comment)

If the connection creation or acquisition encounters an error then the client arg is undefined and the done callback is a no-op function.

Related

n/a

[changeset-bot]

🦋 Changeset detected

Latest commit: 7f65ef9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@effect/sql-pg	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[tim-smart]

👍

Just needs a lint fix and a changeset