Skip to content

Ensure client is defined when catching error #5943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tim-smart merged 4 commits into from
Jan 3, 2026
Merged

Ensure client is defined when catching error #5943

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7b99f9
Ensure client is defined when catching error
sidpremkumar Jan 2, 2026
ebaaab5
self review
sidpremkumar Jan 2, 2026
2bf5760
fix lint + add changeset
sidpremkumar Jan 3, 2026
7f65ef9
Update .changeset/crazy-walls-wait.md
tim-smart Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions packages/sql-pg/src/PgClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,25 +315,25 @@ export const make = (
const fiber = Option.getOrThrow(Fiber.getCurrentFiber())
const scope = Context.unsafeGet(fiber.currentContext, Scope.Scope)
let cause: Error | undefined = undefined
function onError(cause_: Error) {
cause = cause_
}
pool.connect((err, client, release) => {
if (err) {
resume(Effect.fail(new SqlError({ cause: err, message: "Failed to acquire connection for transaction" })))
} else {
resume(Effect.as(
Scope.addFinalizer(
scope,
Effect.sync(() => {
client!.off("error", onError)
release(cause)
})
),
client!
))
return
}
function onError(cause_: Error) {
cause = cause_
}
client!.on("error", onError)
client.on("error", onError)
resume(Effect.as(
Scope.addFinalizer(
scope,
Effect.sync(() => {
client.off("error", onError)
release(cause)
})
),
client
))
})
})
const reserve = Effect.map(reserveRaw, (client) => new ConnectionImpl(client))
Expand Down