Ensure client is defined when catching error #5943
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
We have been seeing errors:
We have tried modifying and guarding better on our application code - but this issue persisted. We think it's coming from here, specifically the
client!assertion that causes the entire app to crash and restart our application.Believe this can be fixed by making sure the client exists before calling on error.
This seems to be known:
Ref: brianc/node-postgres#2492 (comment)
Related
n/a