-
Notifications
You must be signed in to change notification settings - Fork 951
Fix reprobuild #8530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix reprobuild #8530
Conversation
On GitHub where we build the zipfile, it exists, so we don't check out the submodule. If you do, your zipfile won't match! Signed-off-by: Rusty Russell <[email protected]>
…ic PR merged. Signed-off-by: Rusty Russell <[email protected]> Changelog-Fixed: Build: release builds with tools/build-release.sh are deterministic again.
778657e
to
45397b4
Compare
Since we build with To prevent the Docker image publishing issue again which we encountered with CLN v25.09 (resolved in #8531 by installing the released crate directly), we must ensure that installing |
So, tag the commit and add it to Cargo.toml:
? |
I also tried that with the other library ( |
But why?, |
Running
|
Agree, |
Hmpf, this has to be some differently configured git i think. |
I created a local branch repro-utoipa-git-tree to reproduce/test this issue. It contains only the
@rustyrussell Could you please tag this commit in your fork? I attempted to do it myself but received a 403: forbidden error. I can test again once the tag is available. |
This fixes two issues: