Fix Python client TCPTransports not being able to close #390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Choose Correct
Describe the pull request
This PR fixes a problem with the Python implementation of
TCPTransportthat prevented it from closing its TCP connection if it was created as a client.As the field
_serverSockEventStartis only initialized if theTCPTransportis created as a server, callingcloseon a clientTCPTransportresults in anAttributeErrorbeforesocket.closeis called.Thus, the connection stays alive.
To Reproduce
Create a client
TCPTransport, then attempt to callclose()on it.Expected behavior
The
TCPTransportshould close the underlying socket and thus the TCP connection.Desktop (please complete the following information):
Steps you didn't forgot to do