Skip to content

Fix Python client TCPTransports not being able to close #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichalPrincNXP merged 5 commits into from
Feb 9, 2024
Merged

Fix Python client TCPTransports not being able to close #390

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b5d1891
Fix Python client TCPTransports not being able to close
Thom747 Oct 25, 2023
c99abab
Shutdown socket before close
Thom747 Oct 26, 2023
dafd2ab
Merge branch 'develop' into fix-client-tcptransport-close
Thom747 Nov 15, 2023
70d9e68
Replace unnecessary private import
Thom747 Dec 4, 2023
d4d17e8
Merge remote-tracking branch 'Thom747/fix-client-tcptransport-close' …
Thom747 Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion erpc_python/erpc/transport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
import struct
import socket
import threading
from socket import SHUT_RDWR

from .crc16 import Crc16
from .client import RequestError
import time
Expand Down Expand Up @@ -166,7 +168,9 @@ def _serve(self):
self._serverSockEventStart.set()

def close(self):
self._serverSockEventStart.clear()
if self._isServer:
self._serverSockEventStart.clear()
self._sock.shutdown(SHUT_RDWR)
self._sock.close()
self._sock = None

Expand Down