Skip to content

Updated Node version to 22.14.0#543

Merged
mcottontensor merged 11 commits intoEpicGamesExt:masterfrom
Belchy06:version
Mar 24, 2025
Merged

Updated Node version to 22.14.0#543
mcottontensor merged 11 commits intoEpicGamesExt:masterfrom
Belchy06:version

Conversation

@Belchy06
Copy link
Copy Markdown
Collaborator

Relevant components:

  • Signalling server
  • Common library
  • Frontend library
  • Frontend UI library
  • Matchmaker
  • Platform scripts
  • SFU

Problem statement:

Warnings are currently being thrown during npm install regarding an outdated version of Node.

Solution

Bump the Node version used in this repo to that latest LTS: 22.14.0

@mcottontensor
Copy link
Copy Markdown
Collaborator

Just letting this sit here for a bit while i cool off

@@ -1,7 +1,8 @@
FROM node:18.17.0 as builder
FROM node:22.14.0 as builder
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can do something about this being a variable? I'm just trying to remove any hard coded references to the version so if we update it again we have minimal places to update.
Would just using lts be good enough I wonder?

:Init
set SCRIPT_DIR=%~dp0
set NODE_VERSION=v18.17.0
set /p NODE_VERSION=<"%SCRIPT_DIR%/../../../NODE_VERSION"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanity check on the < in this changed file and the one above. That is intentional, yes? (What does it do?)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're redirection operators that are reading the file contents. The opposite of
echo "line" > file.txt

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@lukehb
Copy link
Copy Markdown
Contributor

lukehb commented Mar 24, 2025

Good call on using the NODE_VERSION file!

@mcottontensor mcottontensor merged commit a9d8674 into EpicGamesExt:master Mar 24, 2025
9 checks passed
@mcottontensor
Copy link
Copy Markdown
Collaborator

💚 All backports created successfully

Status Branch Result
UE5.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

mcottontensor added a commit that referenced this pull request Apr 3, 2025
[UE5.5] Merge pull request #543 from Belchy06/version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants