Skip to content

Fixing path issues in platform_scripts #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcottontensor merged 10 commits into from
May 4, 2025
Merged

Fixing path issues in platform_scripts #604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6fe7d4b
feat: Adding script tests where the scripts are run multiple times.
mcottontensor May 2, 2025
115b772
fix: Fixing typo in github action.
mcottontensor May 2, 2025
390791a
gimme a break.
mcottontensor May 2, 2025
3f5d1cd
Adding mutliple script runs for other OSs
mcottontensor May 2, 2025
9e0a6ab
Testing node on the runner
mcottontensor May 2, 2025
549760e
Trying to figure out what node is doing what.
mcottontensor May 2, 2025
8351857
Trying to change the way node version is detected.
mcottontensor May 2, 2025
0638c7d
Messy
mcottontensor May 2, 2025
404e55b
The additions to the script really didn't catch anything. Could be worth
mcottontensor May 2, 2025
6f42f1c
Removing debug print.
mcottontensor May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/healthcheck-platform-scripts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,3 @@ jobs:
run: |
Start-Process -NoNewWindow ".\platform_scripts\cmd\start.bat" -ArgumentList "--rest_api","--player_port 999"
curl --retry 10 --retry-delay 20 --retry-connrefused http://localhost:999/api/status

6 changes: 4 additions & 2 deletions SignallingWebServer/platform_scripts/bash/common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,9 @@ function setup_node() {
# navigate to project root
pushd "${SCRIPT_DIR}/../../.." > /dev/null

# setup the path so we're using our node. required when calling npm
PATH="${SCRIPT_DIR}/node/bin:$PATH"

node_version=""
if [[ -f "${SCRIPT_DIR}/node/bin/node" ]]; then
node_version=$("${SCRIPT_DIR}/node/bin/node" --version)
Expand All @@ -187,14 +190,13 @@ function setup_node() {
else
node_url="https://nodejs.org/dist/$NODE_VERSION/node-$NODE_VERSION-linux-x64.tar.gz"
fi
check_and_install "node" "$node_version" "$NODE_VERSION" "curl $node_url --output node.tar.xz
check_and_install "${SCRIPT_DIR}/node/bin/node" "$node_version" "$NODE_VERSION" "curl $node_url --output node.tar.xz
&& tar -xf node.tar.xz
&& rm node.tar.xz
&& mv node-v*-*-* \"${SCRIPT_DIR}/node\""

if [ $? -eq 1 ] || [ "$INSTALL_DEPS" == "1" ]; then
echo "Installing dependencies..."
PATH="${SCRIPT_DIR}/node/bin:$PATH"
"${NPM}" install
fi

Expand Down
Loading