fix: Version mismatch #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typotter
reviewed
Jan 6, 2025
| @@ -11,7 +11,7 @@ java { | |||
| } | |||
|
|
|||
| group = 'cloud.eppo' | |||
| version = '4.0.1' | |||
There was a problem hiding this comment.
Should we should cut a v4.0.1 release to be consistent? The major version bump was for the change in namespace, so this would be a breaking change.
I have a quick PR that I was going to cut a release for (so I could cut v4.1.0 this afternoon)
There was a problem hiding this comment.
@typotter we never released a v4.0.0 - why not that instead?
There was a problem hiding this comment.
hm. the latest code has a bugfix for respecting graceful mode that was present in "v4.0.0", but since we never released that version, it wasn't really a bugfix. So ya, good idea - we could tag the repo at v4.0.0 now and cut a release.
typotter
reviewed
Jan 6, 2025
typotter
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of this library is v3.1.0. Updated the readme to reflect that and also updated the build.gradle file to point to the next snapshot version