Skip to content

fix: Version mismatch #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2025
Merged

fix: Version mismatch #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

```groovy
dependencies {
implementation 'cloud.eppo:eppo-server-sdk:4.0.1'
implementation 'cloud.eppo:eppo-server-sdk:3.1.0'
}
```

Expand Down Expand Up @@ -58,6 +58,6 @@ repositories {
}

dependencies {
implementation 'cloud.eppo:eppo-server-sdk:3.0.2-SNAPSHOT'
implementation 'cloud.eppo:eppo-server-sdk:3.2.0-SNAPSHOT'
}
```
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ java {
}

group = 'cloud.eppo'
version = '4.0.1'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we should cut a v4.0.1 release to be consistent? The major version bump was for the change in namespace, so this would be a breaking change.
I have a quick PR that I was going to cut a release for (so I could cut v4.1.0 this afternoon)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@typotter we never released a v4.0.0 - why not that instead?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm. the latest code has a bugfix for respecting graceful mode that was present in "v4.0.0", but since we never released that version, it wasn't really a bugfix. So ya, good idea - we could tag the repo at v4.0.0 now and cut a release.

version = '3.2.0-SNAPSHOT'
ext.isReleaseVersion = !version.endsWith("SNAPSHOT")

import org.apache.tools.ant.filters.ReplaceTokens
Expand Down
Loading