Fix browser logging issues #257
Merged
+219
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarsilv
commented
Oct 4, 2025
|
|
||
| [Home](./index.md) > [@eppo/js-client-sdk](./js-client-sdk.md) > [LogLevel](./js-client-sdk.loglevel.md) | ||
|
|
||
| ## LogLevel type |
There was a problem hiding this comment.
New docs auto-generated for the externally exposed method and type for setting the SDK's log level
| { | ||
| "name": "@eppo/js-client-sdk", | ||
| "version": "3.17.0", | ||
| "version": "3.18.0", |
There was a problem hiding this comment.
Bumping minor version because of new public method and type
package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "@eppo/js-client-sdk-common": "4.15.1", | ||
| "@eppo/js-client-sdk-common": "/tmp/packages/js-sdk-common", |
There was a problem hiding this comment.
This will update once js-sdk-common #296 is merged
| }); | ||
| td.verify( | ||
| applicationLogger.error( | ||
| td.matchers.contains({ err: td.matchers.anything() }), |
There was a problem hiding this comment.
Pino API (link) is to have the context object first.
yarn.lock
Outdated
| version "4.15.1" | ||
| resolved "https://registry.yarnpkg.com/@eppo/js-client-sdk-common/-/js-client-sdk-common-4.15.1.tgz#bf2d602b1462eb156224edd73f734a3c99267816" | ||
| integrity sha512-ZVyczDCfAMAnuUlfE293b6h2wfDOcZnfxXHS52r0OU9GktdTYD9EuC3Arpzw4JeTgzV1vW6iTzoz5HDJHwZz6A== | ||
| "@eppo/js-client-sdk-common@/tmp/packages/js-sdk-common": |
There was a problem hiding this comment.
Should update correctly once new version merged
aarsilv
changed the title
sameerank
approved these changes
Oct 5, 2025
| } | ||
|
|
||
| // @public | ||
| export type LogLevel = 'trace' | 'debug' | 'info' | 'warn' | 'error' | 'silent'; |
There was a problem hiding this comment.
We're not supporting 'fatal' in this list?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👯 Related PRs:
js-sdk-common #296Eppo Only:
🎟️ Tickets:
Motivation and Context
This common repository is shared with the Node.js and Browser JavaScript SDKs. The latter won't have a global
process, causing errors unless a dummy globalprocessis defined.Also, currently, logging is hard-coded to be off (silent) for the Browser SDK. However, having logs can be helpful, especially for debugging.
Description
Use the latest common sdk with the updated application logger that now works with browsers.
Expose the
setLogLevel()method for adjusting log levels.Also clean up existing logger statements to fit Pino API of having the context object first.
How has this been documented?
eppo-docs #698- Documentation for setLogLevel()How has this been tested?
process. Also I saw no logs by default, error if I provided a bad SDK key, and then all the info logs if I changed the log level on purpose.