Fix browser logging fixes #296
Merged
+20
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarsilv
commented
Oct 4, 2025
| // Use any specified log level, or warn in production/browser, info otherwise | ||
| /* eslint-disable no-restricted-globals */ | ||
| level: | ||
| typeof process !== 'undefined' && process.env.LOG_LEVEL |
There was a problem hiding this comment.
🔧 The fix: we now check that process is defined before accessing
| } catch (err: any) { | ||
| logger.error('Error logging bandit event', err); | ||
| } catch (err) { | ||
| logger.error({ err }, 'Error logging bandit event'); |
There was a problem hiding this comment.
Pino's API (link) is to have context first, then the log message.
aarsilv
changed the title
sameerank
approved these changes
Oct 5, 2025
| ? process.env.LOG_LEVEL | ||
| : typeof process === 'undefined' || process.env.NODE_ENV === 'production' | ||
| ? 'warn' | ||
| : 'info', |
There was a problem hiding this comment.
https://getpino.io/#/docs/api?id=level-string
Looks like it defaults to 'info' anyway, but I like that it's explicit here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👯 Related PR:
js-client-sdk #257Eppo Only:
🎟️ Tickets:
Motivation and Context
This common repository is shared with the Node.js and Browser JavaScript SDKs. The latter won't have a global
process, causing errors unless a dummy globalprocessis defined.Also, currently, logging is hard-coded to be off (silent) for the Browser SDK. However, having logs can be helpful, especially for debugging.
Description
This PR does not assume
processwill be defined.It also changes the logger's default log level for browser to be
warninstead of forced off. There is a newsetLogLevel()method that can be called to change that if desired.How has this been documented?
eppo-docs #698- Documentation for setLogLevel()How has this been tested?
process. Also I saw no logs by default, error if I provided a bad SDK key, and then all the info logs if I changed the log level on purpose.