fix: Use js-base64 polyfill instead of Buffer for browser env
#159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipecsl
changed the title
Buffer for browser env
greghuels
reviewed
Dec 4, 2024
| if (!encodedPayload) return null; | ||
|
|
||
| const decodedPayload = Buffer.from(encodedPayload, 'base64url').toString('utf-8'); | ||
| const decodedPayload = Base64.decode(encodedPayload); |
greghuels
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Replace usage of
Bufferwithjs-base64polyfill for browser environmentDescription
It looks like
Base64.decodeis able to parse both flavors of base64-encoded strings (regular and url-safe'base64url'encoding), so this is a safe change. The docs also mention that explicitly https://github.com/dankogai/js-base64?tab=readme-ov-file#synopsisHow has this been tested?
Wrote another test
Related to Eppo-exp/js-client-sdk#115