fix: Update configuration stores in ConfigurationRequestor when they are changed on the client
#257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameerank
approved these changes
Mar 20, 2025
| }); | ||
|
|
||
| describe('IConfigurationStore updates', () => { | ||
| it('should update configuration when stores are changed', async () => { |
typotter
deleted the
typo/ff-4161-js-common-singleton-instance-cannot-be-offline-init-after
branch
typotter
added a commit
that referenced
this pull request
Apr 22, 2025
…y are changed on the client (#257) * reset config stores in the config requestor when set on the client * tests * v4.14.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels: mergeable
Fixes FF-4161
Motivation and Context
Not updating the Config Stores on the Config Requestor means that the dev can call
setFlagConfigurationStorewithout any effect. This actually causes test failures downstream where we are using and abusing the same client instance for all the tests.This bug is blocking integrating the latest common downstream.
Description
How has this been tested?