Skip to content

feat: add character contacts#413

Merged
ErikKalkoken merged 4 commits intomainfrom
feat-character-contacts
Mar 4, 2026
Merged

feat: add character contacts#413
ErikKalkoken merged 4 commits intomainfrom
feat-character-contacts

Conversation

@ErikKalkoken
Copy link
Owner

@ErikKalkoken ErikKalkoken commented Mar 2, 2026

This PR adds the character contacts feature:

  • Shows all character contacts with standing
  • For each contract shows category, contact labels and whether they are a NPC
  • Contact list can be filtered by various topics and searched

Screenshot:

image

@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 27.48092% with 570 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.6%. Comparing base (72633a9) to head (1ec7c59).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
internal/app/ui/charactercontacts.go 4.2% 366 Missing and 14 partials ⚠️
internal/app/storage/charactercontact.go 62.0% 26 Missing and 26 partials ⚠️
internal/app/testutil/factory.go 0.0% 43 Missing ⚠️
internal/app/characterservice/contacts.go 71.8% 15 Missing and 12 partials ⚠️
internal/app/contact.go 0.0% 26 Missing ⚠️
internal/app/storage/charactercontactlabel.go 69.2% 8 Missing and 8 partials ⚠️
internal/app/ui/desktopui.go 0.0% 5 Missing ⚠️
internal/app/characterservice/section.go 0.0% 4 Missing ⚠️
internal/app/ui/mobileui.go 0.0% 4 Missing ⚠️
internal/app/ui/updateticker.go 0.0% 4 Missing ⚠️
... and 3 more
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #413     +/-   ##
=======================================
- Coverage   34.7%   34.6%   -0.2%     
=======================================
  Files        246     251      +5     
  Lines      40128   40908    +780     
=======================================
+ Hits       13939   14168    +229     
- Misses     24073   24562    +489     
- Partials    2116    2178     +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ErikKalkoken ErikKalkoken marked this pull request as ready for review March 3, 2026 18:35
@ErikKalkoken ErikKalkoken force-pushed the feat-character-contacts branch 2 times, most recently from 43ff7a9 to 34e350d Compare March 3, 2026 22:01
@ErikKalkoken ErikKalkoken force-pushed the feat-character-contacts branch from 34e350d to 1ec7c59 Compare March 3, 2026 22:22
@ErikKalkoken ErikKalkoken merged commit 4bc4f2d into main Mar 4, 2026
10 checks passed
@ErikKalkoken ErikKalkoken deleted the feat-character-contacts branch March 4, 2026 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant