Skip to content

feat: add character contacts #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ErikKalkoken merged 4 commits into from
Mar 4, 2026

feat: improve contact labels

1ec7c59
Select commit
Loading
Failed to load commit list.
Merged

feat: add character contacts #413

feat: improve contact labels
1ec7c59
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 3, 2026 in 0s

34.6% (-0.2%) compared to 72633a9

View this Pull Request on Codecov

34.6% (-0.2%) compared to 72633a9

Details

Codecov Report

❌ Patch coverage is 27.48092% with 570 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.6%. Comparing base (72633a9) to head (1ec7c59).

Files with missing lines Patch % Lines
internal/app/ui/charactercontacts.go 4.2% 366 Missing and 14 partials ⚠️
internal/app/storage/charactercontact.go 62.0% 26 Missing and 26 partials ⚠️
internal/app/testutil/factory.go 0.0% 43 Missing ⚠️
internal/app/characterservice/contacts.go 71.8% 15 Missing and 12 partials ⚠️
internal/app/contact.go 0.0% 26 Missing ⚠️
internal/app/storage/charactercontactlabel.go 69.2% 8 Missing and 8 partials ⚠️
internal/app/ui/desktopui.go 0.0% 5 Missing ⚠️
internal/app/characterservice/section.go 0.0% 4 Missing ⚠️
internal/app/ui/mobileui.go 0.0% 4 Missing ⚠️
internal/app/ui/updateticker.go 0.0% 4 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@           Coverage Diff           @@
##            main    #413     +/-   ##
=======================================
- Coverage   34.7%   34.6%   -0.2%     
=======================================
  Files        246     251      +5     
  Lines      40128   40908    +780     
=======================================
+ Hits       13939   14168    +229     
- Misses     24073   24562    +489     
- Partials    2116    2178     +62

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov