Skip to content

Fix missing hyphen values parsing clap commands definition #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ErikReider merged 2 commits into from
Dec 9, 2025
Merged

Fix missing hyphen values parsing clap commands definition #193

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5286c18
Fix missing hyphen values parsing clap commands definition
busybox11 Dec 9, 2025
b09d3d6
review: Use allow_negative_numbers instead of allow_hyphen_values
busybox11 Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions src/args.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,19 @@ pub struct ArgsClient {
pub scroll_lock_led: Option<String>,

/// Shows volume osd and raises, loweres or mutes default sink volume
#[arg(long, value_name = "raise|lower|mute-toggle|(±)number")]
#[arg(
long,
value_name = "raise|lower|mute-toggle|(±)number",
allow_negative_numbers = true
)]
pub output_volume: Option<String>,

/// Shows volume osd and raises, loweres or mutes default source volume
#[arg(long, value_name = "raise|lower|mute-toggle|(±)number")]
#[arg(
long,
value_name = "raise|lower|mute-toggle|(±)number",
allow_negative_numbers = true
)]
pub input_volume: Option<String>,

/// Sets the maximum Volume
Expand All @@ -76,7 +84,11 @@ pub struct ArgsClient {
pub device: Option<String>,

/// Shows brightness osd and raises or loweres all available sources of brightness device
#[arg(long, value_name = "raise|lower|(±)number")]
#[arg(
long,
value_name = "raise|lower|(±)number",
allow_negative_numbers = true
)]
pub brightness: Option<String>,

/// Sets the minimum Brightness
Expand Down