Fix missing hyphen values parsing clap commands definition#193
Merged
ErikReider merged 2 commits intoErikReider:mainfrom Dec 9, 2025
Merged
Fix missing hyphen values parsing clap commands definition#193ErikReider merged 2 commits intoErikReider:mainfrom
ErikReider merged 2 commits intoErikReider:mainfrom
Conversation
busybox11
force-pushed
the
fix-output-volume-parse
branch
from
fa4b521 to
05e09d2
Compare
Contributor
Author
|
(forgot to format the code, CI was failing - reverted and force pushed my formatted commit not to mess up the git history with a useless fmt commit) |
ErikReider
requested changes
Dec 9, 2025
Owner
ErikReider
left a comment
ErikReider
left a comment
There was a problem hiding this comment.
Good find! I think allow_negative_numbers should be a better fit though :)
Contributor
Author
|
Good call, rebasing and pushing this instead. Thank you for the heads up! |
busybox11
force-pushed
the
fix-output-volume-parse
branch
from
61c18c8 to
07ec6c6
Compare
Contributor
Author
|
@ErikReider updated and fixed! hm, ci still fails but cargo fmt doesn't.. not sure if something is misconfused on my end, i dont do a lot of rust dev. fixing this by hand for now |
busybox11
force-pushed
the
fix-output-volume-parse
branch
from
07ec6c6 to
b09d3d6
Compare
Contributor
Author
|
you're very welcome :) thanks for this incredible project, love it very much with swaync too <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #192