Skip to content

Conversation

@fcjoe-gis
Copy link

Copy link
Contributor

@prathameshnarkhede prathameshnarkhede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate your efforts on this!

This comment was marked as outdated.

This comment was marked as outdated.

@prathameshnarkhede
Copy link
Contributor

There appears to be an issue with line endings that might need to be addressed separately. I attempted to fix the extra spaces added after the UpdateVisibility(); call, but ran into challenges both locally and in GitHub's online editor when trying to make just that minor change. We can revisit this in a future pull request to ensure a cleaner update.

@fcjoe-gis
Copy link
Author

@prathameshnarkhede

I was seeing some weird behavior with whitespace when I added the lines using Rider on Mac, which is my main development environment. So I just tried to just add the code in a text editor so it would not show a ton of 'ghost' (the same lines were showing as removed and added) changes to the file. Not sure if making the fix in Visual Studio would be better

@dotMorten dotMorten requested a review from Copilot August 22, 2025 22:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Collapses the search source dropdown dialog when users begin typing in the search field.

  • Automatically hides the source selection dropdown when text is entered in the search field
  • Updates UI visibility state to reflect the collapsed dropdown

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

{
if (SearchViewModel != null)
{
//JH: Added for collapsing dialog when user starts typing in search
Copy link

Copilot AI Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personal identifier comments ('JH:') should be removed from production code. Consider using a more descriptive comment that explains the business logic instead.

Suggested change
//JH: Added for collapsing dialog when user starts typing in search
// Collapse the source selection dialog when the user starts typing in the search box

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants