-
Notifications
You must be signed in to change notification settings - Fork 128
Add code to collapse dialog if search source dropdown visible and user start to type in search #691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…r start to type in search
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate your efforts on this!
Co-authored-by: Copilot <[email protected]>
|
There appears to be an issue with line endings that might need to be addressed separately. I attempted to fix the extra spaces added after the |
|
I was seeing some weird behavior with whitespace when I added the lines using Rider on Mac, which is my main development environment. So I just tried to just add the code in a text editor so it would not show a ton of 'ghost' (the same lines were showing as removed and added) changes to the file. Not sure if making the fix in Visual Studio would be better |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Collapses the search source dropdown dialog when users begin typing in the search field.
- Automatically hides the source selection dropdown when text is entered in the search field
- Updates UI visibility state to reflect the collapsed dropdown
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| { | ||
| if (SearchViewModel != null) | ||
| { | ||
| //JH: Added for collapsing dialog when user starts typing in search |
Copilot
AI
Aug 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personal identifier comments ('JH:') should be removed from production code. Consider using a more descriptive comment that explains the business logic instead.
| //JH: Added for collapsing dialog when user starts typing in search | |
| // Collapse the source selection dialog when the user starts typing in the search box |
#686