Skip to content

Add code to collapse dialog if search source dropdown visible and user start to type in search #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add code to collapse dialog if search source dropdown visible and user start to type in search #691

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4df020e
Add code to collapse dialog if search source dropdown visible and use…
fcjoe-gis Aug 22, 2025
46371c3
Update src/Toolkit/Toolkit.Maui/SearchView/SearchView.cs
prathameshnarkhede Aug 22, 2025
4850add
Update SearchView.cs
prathameshnarkhede Aug 22, 2025
d2c9786
Revert "Update src/Toolkit/Toolkit.Maui/SearchView/SearchView.cs"
prathameshnarkhede Aug 22, 2025
1d8f7d9
Merge branch 'one-mo-time' of https://github.com/ramtechjoe/arcgis-ma…
prathameshnarkhede Aug 22, 2025
1c3114b
Fixing spaces
prathameshnarkhede Aug 22, 2025
60f64f9
Revert "Fixing spaces"
prathameshnarkhede Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Toolkit/Toolkit.Maui/SearchView/SearchView.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,9 @@ private void PART_Entry_TextChanged(object? sender, TextChangedEventArgs e)
{
if (SearchViewModel != null)
{
//JH: Added for collapsing dialog when user starts typing in search
Copy link

Copilot AI Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personal identifier comments ('JH:') should be removed from production code. Consider using a more descriptive comment that explains the business logic instead.

Suggested change
//JH: Added for collapsing dialog when user starts typing in search
// Collapse the source selection dialog when the user starts typing in the search box

Copilot uses AI. Check for mistakes.
_sourceSelectToggled = false;
UpdateVisibility();
SearchViewModel.CurrentQuery = e.NewTextValue;
}
}
Expand Down
Loading