-
-
Notifications
You must be signed in to change notification settings - Fork 20
Notice`s package-private #1197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Notice`s package-private #1197
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -35,15 +35,14 @@ void executeChat(@Flag("-raw") boolean raw, @Join String text) { | |||||||||||||||||||||
} | ||||||||||||||||||||||
|
||||||||||||||||||||||
@Execute(name = "title") | ||||||||||||||||||||||
@DescriptionDocs(description = "Broadcasts a TITLE message to all players.", arguments = "[-raw] <text>") | ||||||||||||||||||||||
void executeTitle(@Flag("-raw") boolean raw, @Join String title) { | ||||||||||||||||||||||
this.sendBroadcast(formatted -> Notice.title(formatted, "", this.settings.titleFadeIn(), this.settings.titleStay(), this.settings.titleFadeOut()), title, raw); | ||||||||||||||||||||||
} | ||||||||||||||||||||||
@DescriptionDocs(description = "Broadcasts a combined title message to all players.", arguments = "[-raw] <text>") | ||||||||||||||||||||||
void executeTitle(@Flag("-raw") boolean raw, @Join String text) { | ||||||||||||||||||||||
|
||||||||||||||||||||||
@Execute(name = "subtitle") | ||||||||||||||||||||||
@DescriptionDocs(description = "Broadcasts a SUBTITLE message to all players.", arguments = "[-raw] <text>") | ||||||||||||||||||||||
void executeSubtitle(@Flag("-raw") boolean raw, @Join String subtitle) { | ||||||||||||||||||||||
this.sendBroadcast(formatted -> Notice.title("", formatted, this.settings.titleFadeIn(), this.settings.titleStay(), this.settings.titleFadeOut()), subtitle, raw); | ||||||||||||||||||||||
this.noticeService.create() | ||||||||||||||||||||||
.notice(translation -> Notice.title(raw ? " " : translation.broadcast().messageFormat(), text, | ||||||||||||||||||||||
this.settings.titleFadeIn(), this.settings.titleStay(), this.settings.titleFadeOut())) | ||||||||||||||||||||||
.onlinePlayers() | ||||||||||||||||||||||
.send(); | ||||||||||||||||||||||
Comment on lines
+41
to
+45
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The new implementation of
If the intention is for this command to now broadcast a subtitle (as Here is a suggested implementation that would make
Suggested change
|
||||||||||||||||||||||
} | ||||||||||||||||||||||
|
||||||||||||||||||||||
@Execute(name = "actionbar") | ||||||||||||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
te zmiany na pewno są do tego PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jeszcze widzę parę usuniętych plików
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oj przez przypadek się połączyły poprawie to ;)