Skip to content

Fix detach view delegate #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix detach view delegate #271

wants to merge 1 commit into from

Conversation

ryanlntn
Copy link
Contributor

@ryanlntn ryanlntn commented Sep 8, 2023

Fixes: #230

Moving detachViewDelegate to viewDidDisappear fixes swipe to dismiss but unfortunately it doesn't appear to get called consistently when leaving the share extension with continueInApp, openApp, or dismissExtension. This updates those methods to also detachViewDelegate fixing the subsequent crash on launch.

jorgegvallejo
jorgegvallejo approved these changes Nov 21, 2023
View reviewed changes
Copy link

@jorgegvallejo jorgegvallejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests ok on RN 0.70.3

@lindboe lindboe mentioned this pull request Dec 6, 2023
Open
21 tasks
@lindboe lindboe mentioned this pull request Feb 8, 2024
Closed
@vincentritter vincentritter mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jorgegvallejo jorgegvallejo jorgegvallejo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

continueInApp() only works every other time
2 participants
@ryanlntn @jorgegvallejo