Fix checkpoint value parsing#2311
Conversation
timfelle
left a comment
There was a problem hiding this comment.
The checkpoint options are kinda funky now.
If a user does not specify case.output_checkpoints at all, then we expect they intend to save checkpoints. Therefore it is mandatory to have case.checkpoint_control in the case file, since we now removed the default value for that. Is that really intentional?Or would it not be more intuitive for the default of case.output_checkpoints to be false, since if a user wants checkpoints, they probably know how they want them to be spaced.
This currently cause the rayleigh_benard case to fail.
Ugh, yeah, good catch! I guess both defaults are defensible; we can discuss at the meeting today! |
timfelle
left a comment
There was a problem hiding this comment.
Also missing changelog update
Fix issue #2301.
Additionally, fixes some default values to be the same as in the documentation (no defaults).