Skip to content

Comments

Fix checkpoint value parsing#2311

Open
timofeymukha wants to merge 8 commits intoExtremeFLOW:developfrom
timofeymukha:fix/checkpoint_init
Open

Fix checkpoint value parsing#2311
timofeymukha wants to merge 8 commits intoExtremeFLOW:developfrom
timofeymukha:fix/checkpoint_init

Conversation

@timofeymukha
Copy link
Collaborator

Fix issue #2301.

Additionally, fixes some default values to be the same as in the documentation (no defaults).

@timofeymukha timofeymukha added the bug Something isn't working label Feb 9, 2026
Copy link
Collaborator

@timfelle timfelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checkpoint options are kinda funky now.

If a user does not specify case.output_checkpoints at all, then we expect they intend to save checkpoints. Therefore it is mandatory to have case.checkpoint_control in the case file, since we now removed the default value for that. Is that really intentional?Or would it not be more intuitive for the default of case.output_checkpoints to be false, since if a user wants checkpoints, they probably know how they want them to be spaced.

This currently cause the rayleigh_benard case to fail.

@timofeymukha
Copy link
Collaborator Author

The checkpoint options are kinda funky now.

If a user does not specify case.output_checkpoints at all, then we expect they intend to save checkpoints. Therefore it is mandatory to have case.checkpoint_control in the case file, since we now removed the default value for that. Is that really intentional? Or would it not be more intuitive for the default of case.output_checkpoints to be false, since if a user wants checkpoints, they probably know how they want them to be spaced.

This currently cause the rayleigh_benard case to fail.

Ugh, yeah, good catch! I guess both defaults are defensible; we can discuss at the meeting today!

Copy link
Collaborator

@timfelle timfelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also missing changelog update

@njansson njansson enabled auto-merge (squash) February 13, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants