Skip to content

Fix checkpoint value parsing #2311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timofeymukha wants to merge 8 commits into
base: develop
Choose a base branch
from
+59 −16
Open

Fix checkpoint value parsing #2311

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5304a0f
Fix
timofeymukha Feb 9, 2026
5e61ee0
Merge branch 'develop' into fix/checkpoint_init
timfelle Feb 10, 2026
1efbc7a
No default for output_checkpoints
timofeymukha Feb 24, 2026
de0ea0f
Merge branch 'develop' into fix/checkpoint_init
timofeymukha Feb 24, 2026
e52ce57
Add docs, fix "never"
timofeymukha Feb 24, 2026
e30a1b4
Add docs
timofeymukha Feb 24, 2026
df65b59
Typos
timofeymukha Feb 24, 2026
aa46dda
Doc
timofeymukha Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions src/case.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,19 +510,19 @@ subroutine case_init_common(this)
always_write_mesh = logical_val)
end if

call json_get_or_default(this%params, 'case.fluid.output_control',&
string_val, 'org')
call json_get(this%params, 'case.fluid.output_control', string_val)

if (trim(string_val) .eq. 'org') then
! yes, it should be real_val below for type compatibility
call json_get(this%params, 'case.nsamples', integer_val)
call json_get_or_lookup(this%params, 'case.nsamples', integer_val)
real_val = real(integer_val, kind=rp)
call this%output_controller%add(this%f_out, real_val, 'nsamples')
else if (trim(string_val) .eq. 'never') then
call this%output_controller%add(this%f_out, 0.0_rp, 'never')
else if (trim(string_val) .eq. 'tsteps' .or. &
trim(string_val) .eq. 'nsamples') then
call json_get(this%params, 'case.fluid.output_value', integer_val)
call json_get_or_lookup(this%params, 'case.fluid.output_value', &
integer_val)
real_val = real(integer_val, kind=rp)
call this%output_controller%add(this%f_out, real_val, string_val)
else if (trim(string_val) .eq. 'simulationtime') then
Expand All @@ -545,10 +545,18 @@ subroutine case_init_common(this)
string_val, "chkp")
call this%chkp_out%init(this%chkp, name = name,&
path = this%output_directory, fmt = trim(string_val))
call json_get_or_default(this%params, 'case.checkpoint_control', &
string_val, "simulationtime")
call json_get_or_lookup_or_default(this%params, &
'case.checkpoint_value', real_val, 1e10_rp)
call json_get(this%params, 'case.checkpoint_control', &
string_val)
if (trim(string_val) .eq. 'tsteps' .or. &
trim(string_val) .eq. 'nsamples') then
call json_get_or_lookup(this%params, 'case.checkpoint_value', &
integer_val)
real_val = real(integer_val, kind=rp)
else if (trim(string_val) .eq. 'simulationtime') then
call json_get_or_lookup(this%params, 'case.checkpoint_value', &
real_val)
end if

call this%output_controller%add(this%chkp_out, real_val, string_val, &
NEKO_EPS)
end if
Expand Down
Loading