Skip to content

[feature] Support docker compose as plugin#137

Merged
Ramon-Jimenez merged 6 commits intodevelopmentfrom
fix/use-docker-compose-v2
Jun 5, 2025
Merged

[feature] Support docker compose as plugin#137
Ramon-Jimenez merged 6 commits intodevelopmentfrom
fix/use-docker-compose-v2

Conversation

@tokland
Copy link
Copy Markdown
Contributor

@tokland tokland commented Feb 19, 2025

Detected on: https://app.clickup.com/t/2he0te1, https://app.clickup.com/t/1mufv53

This one was tricky. Latest Docker package upgrades are making it increasingly difficult to make docker-compose work. See, for example:

We can no longer delay the upgrade from docker-compose to docker compose (as a plugin), which is the modern recommended approach. Ubuntu systems support this through the docker-compose-v2 package.

  • Change code to use "docker compose" instead of docker-compose
  • Update README

Note that the docker compose plugin is a drop-in replacement a docker-compose, but it has been completely rewritten (python -> go). so this is not a breaking change, but definitely we should keep an eye to see all the configurations used in EST keep working. I've tested with SP and my local dockers, and for now, everything works as before.

Copy link
Copy Markdown
Contributor

@cgbautista cgbautista May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to update the requirements, since now it is using "docker compose (v2)" which requires docker v20.10.13 (according to https://www.howtogeek.com/devops/how-to-upgrade-to-docker-compose-v2/ )

- Docker >= 20.10.13
- Docker compose >= 2

@tokland
Copy link
Copy Markdown
Contributor Author

tokland commented Jun 5, 2025

  • Merge with development
  • Use setuptools and importlib (modern approach)
  • Test in sp-cpr-test

@Ramon-Jimenez Ramon-Jimenez merged commit 9ee0d7a into development Jun 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants