implement more rigorous checks of compressed payloads#686
Merged
Conversation
lukaspie
commented
Aug 4, 2025
lukaspie
force-pushed
the
compresssion-checks
branch
from
ba340ca to
90e0434
Compare
lukaspie
changed the title
lukaspie
force-pushed
the
compresssion-checks
branch
from
d260f08 to
ea0c65a
Compare
lukaspie
commented
Aug 4, 2025
mkuehbach
reviewed
Aug 4, 2025
mkuehbach
reviewed
Aug 4, 2025
mkuehbach
reviewed
Aug 4, 2025
mkuehbach
reviewed
Aug 4, 2025
mkuehbach
reviewed
Aug 4, 2025
mkuehbach
reviewed
Aug 4, 2025
mkuehbach
reviewed
Aug 4, 2025
mkuehbach
requested changes
Aug 4, 2025
Collaborator
mkuehbach
left a comment
mkuehbach
left a comment
There was a problem hiding this comment.
Thank you for the discussion and having a look into it, testing it on em showed the fix to resolve the issue. Polishing comments.
Merged
Collaborator
Author
|
@mkuehbach should be ready to be merged. Let's make a new release afterwards, see #688 |
Collaborator
Agreed, merge this PR, wrt to the connection to #688 I commented there. |
mkuehbach
approved these changes
Aug 6, 2025
Collaborator
mkuehbach
left a comment
mkuehbach
left a comment
There was a problem hiding this comment.
All changes were addressed professionally.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #684, we currently have a bug that compressed values for the sake of type checking get unpacked, but they are also passed to the writer unpacked (entirely removing the compression). We remove that check in #685, but then again, we do not check that the compressed value is actually valid.
This PR applies the same checking logic that we had for native types also do dicts like
{"compress": value, strength: 1}, using the same function to check in both cases.