Skip to content

prepare v0.11.1#688

Merged
lukaspie merged 5 commits intomasterfrom
prepare-v0.11.1
Aug 7, 2025
Merged

prepare v0.11.1#688
lukaspie merged 5 commits intomasterfrom
prepare-v0.11.1

Conversation

@lukaspie
Copy link
Collaborator

@lukaspie lukaspie commented Aug 6, 2025

This is contingent upon #686 being merged first.

@lukaspie lukaspie marked this pull request as ready for review August 6, 2025 08:19
@lukaspie lukaspie requested a review from mkuehbach August 6, 2025 08:19
Copy link
Collaborator

@mkuehbach mkuehbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes made are good. This release though if that should support the EBSD database processing for the MC needs to have this one merged FAIRmat-NFDI/nexus_definitions#406 and the definitions used in that v0.11.1 proposed here updated for the EM EBSD example to be functional. Let's discuss tmrw on our 1pm meeting @lukaspie

@mkuehbach
Copy link
Collaborator

mkuehbach commented Aug 6, 2025

https://github.com/FAIRmat-NFDI/pynxtools/blob/853f55a7d6be361106aa3f3918692401ef0cfea5/docs/learn/multi-format-reader.md L269 NXlens_em to NXelectromagnetic_lens from https://github.com/FAIRmat-NFDI/pynxtools/pull/667/files needs addition here, NXlens_em is no longer a base class in the defs that v0.11.1 will use

@lukaspie
Copy link
Collaborator Author

lukaspie commented Aug 7, 2025

853f55a/docs/learn/multi-format-reader.md L269 NXlens_em to NXelectromagnetic_lens from #667 (files) needs addition here, NXlens_em is no longer a base class in the defs that v0.11.1 will use

I added that change directly to this branch

@lukaspie
Copy link
Collaborator Author

lukaspie commented Aug 7, 2025

The changes made are good. This release though if that should support the EBSD database processing for the MC needs to have this one merged FAIRmat-NFDI/nexus_definitions#406 and the definitions used in that v0.11.1 proposed here updated for the EM EBSD example to be functional. Let's discuss tmrw on our 1pm meeting @lukaspie

I updated the definitions accordingly.

… EM and APM (#692)

Co-authored-by: mkuehbach <markus.kuehbach@physik.hu-berlin.de>
Copy link
Collaborator

@mkuehbach mkuehbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now, feel free to merge and release v0.11.1, provided that all checks run through successfully

@lukaspie lukaspie merged commit bd5c92e into master Aug 7, 2025
24 of 25 checks passed
@lukaspie lukaspie deleted the prepare-v0.11.1 branch August 7, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants