Conversation
mkuehbach
left a comment
There was a problem hiding this comment.
The changes made are good. This release though if that should support the EBSD database processing for the MC needs to have this one merged FAIRmat-NFDI/nexus_definitions#406 and the definitions used in that v0.11.1 proposed here updated for the EM EBSD example to be functional. Let's discuss tmrw on our 1pm meeting @lukaspie
|
https://github.com/FAIRmat-NFDI/pynxtools/blob/853f55a7d6be361106aa3f3918692401ef0cfea5/docs/learn/multi-format-reader.md L269 NXlens_em to NXelectromagnetic_lens from https://github.com/FAIRmat-NFDI/pynxtools/pull/667/files needs addition here, NXlens_em is no longer a base class in the defs that v0.11.1 will use |
I added that change directly to this branch |
4546eee to
0c24eb5
Compare
0c24eb5 to
efe8997
Compare
I updated the definitions accordingly. |
… EM and APM (#692) Co-authored-by: mkuehbach <markus.kuehbach@physik.hu-berlin.de>
This is contingent upon #686 being merged first.