-
Notifications
You must be signed in to change notification settings - Fork 831
Localize various elements #2426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Hint_EditingSpawnlists=You can edit your spawnlists by drag and dropping icons around and inbetween spawnlists\! | ||
| Hint_EditingSpawnlistsSave=Press \"Save Changes\" to save any changes made to your spawnlists\! | ||
|
|
||
| hint_keyquotations='%s' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We absolutely do not need to "localize" single quotes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? I've seen Russian translates it as guillemets (« »). Or maybe it would look better when completely removed in translated version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine as is. There's no need to change it. This would be at best a visual change that serves no purpose of localization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But that's the point of localization(?). I don't know if it will overload localization system, so if it really matters i can change it in a few
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No? The point of localization is not to randomly use fancy quotation marks only for some languages, it's to translate to languages people know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay i'm not gonna argue that because quotation marks is a part of text as words are...
I'm just gonna apply your changes then
| servers_find=Find servers at given address | ||
| gamemodename_unknown=Unknown Gamemode | ||
| gameversionname_unknown=Unknown version | ||
| server_no_map=no_map |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Map names (server_no_map) do not need translation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still shows up to client so i will leave it localizable 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, then I can't really merge the Pull Request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not? Key name is not that long and it shows to the player...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of map names are just file names so, i'm assuring that i won't be making this happen. Plus on this case it's just a static text of a map file name that not even exist, sorry for my zeal to add most of the text to localization files.
garrysmod/gamemodes/sandbox/entities/weapons/gmod_tool/stools/duplicator.lua
Show resolved
Hide resolved
Co-Authored-By: Rubat <[email protected]>
Co-Authored-By: Rubat <[email protected]>
Co-Authored-By: Rubat <[email protected]>
Pending other changes
Made few stuff localizable, feel free to suggest changes!
Duplicator tool texts & Local dupe tooltip

Key name quotation & Not bound key quotationremoved upon requestLocal map save tooltip

Different map save loading window

Preset saving window buttons

Chromium credits window titleremoved upon requestNo map name for Unreachable serversremoved upon requestUnknown author label
