Skip to content

Conversation

@Blueberryy
Copy link
Contributor

@Blueberryy Blueberryy commented Jan 20, 2026

Made few stuff localizable, feel free to suggest changes!

Duplicator tool texts & Local dupe tooltip
2026_01_20_0rc_Kleki

2026_01_20_0rd_Kleki

Key name quotation & Not bound key quotation removed upon request
2026_01_20_0re_Kleki
2026_01_20_0rf_Kleki

Local map save tooltip
2026_01_20_0rg_Kleki

Different map save loading window
2026_01_20_0rg_Kleki(1)

Preset saving window buttons
2026_01_20_0rh_Kleki

Chromium credits window title removed upon request
2026_01_20_0rh_Kleki(1)

No map name for Unreachable servers removed upon request
2026_01_20_0rp_Kleki

Unknown author label
2026_01_20_0s1_Kleki

Hint_EditingSpawnlists=You can edit your spawnlists by drag and dropping icons around and inbetween spawnlists\!
Hint_EditingSpawnlistsSave=Press \"Save Changes\" to save any changes made to your spawnlists\!

hint_keyquotations='%s'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We absolutely do not need to "localize" single quotes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? I've seen Russian translates it as guillemets (« »). Or maybe it would look better when completely removed in translated version

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine as is. There's no need to change it. This would be at best a visual change that serves no purpose of localization.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that's the point of localization(?). I don't know if it will overload localization system, so if it really matters i can change it in a few

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No? The point of localization is not to randomly use fancy quotation marks only for some languages, it's to translate to languages people know?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay i'm not gonna argue that because quotation marks is a part of text as words are...
I'm just gonna apply your changes then

servers_find=Find servers at given address
gamemodename_unknown=Unknown Gamemode
gameversionname_unknown=Unknown version
server_no_map=no_map
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Map names (server_no_map) do not need translation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still shows up to client so i will leave it localizable 😄

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, then I can't really merge the Pull Request.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not? Key name is not that long and it shows to the player...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it sets a precedent for map names to be translated. There are already cases of people perhaps taking it too far.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of map names are just file names so, i'm assuring that i won't be making this happen. Plus on this case it's just a static text of a map file name that not even exist, sorry for my zeal to add most of the text to localization files.

@robotboy655 robotboy655 added the Enhancement The pull request enhances current functionality. label Jan 20, 2026
@robotboy655 robotboy655 merged commit a9841fc into Facepunch:master Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement The pull request enhances current functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants