Add Azure Service Bus facets yaml and output type #248

RoguedBear · 2025-02-07T11:12:56Z

Description

Caution

This module consumes output from azure_vpc which at the current stage is not supported. That issue is tracked in: https://app.clickup.com/t/3443930/86cxxyckf

adds facets.yaml for Azure Service Bus

Related issues

none

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist

I have created feat/bugfix branch out of develop branch
Code passes linting/formatting checks
Changes to resources have been tested in our dev environments
I have made corresponding changes to the documentation

Testing

Reviewer instructions

* if price is 0, exclude from dataset * removed .DS_Store * added generated files

This reverts commit d95ff4a03b0c9af774836205222e5a7f80b3610f.

This reverts commit 06034ac40e84b1b19cf139c597953309ad694a7e.

* upadted facets-module * upadted facets-module * updated overrides for domains * updated overrides for domains * updated port name * updated port name

* Added artifactories facets modules * added schema * updated spec * changed type to string * updated to null * introduced indentation * updated spec * updated spec to have include_all false as default * updated type from bool to boolean

* Fix mismatches in sample jsons * Remove unintended change

This reverts commit a6777ed.

* updated port name * added a space * updated message

* updated message * updated message * updated message * updated message * updated message * updated message * updated message * updated message * updated to use s3 as default support for lambda * removed release

* if price is 0, exclude from dataset * removed .DS_Store * added generated files

This reverts commit d95ff4a03b0c9af774836205222e5a7f80b3610f.

This reverts commit 06034ac40e84b1b19cf139c597953309ad694a7e.

* Added artifactories facets modules * added schema * updated spec * changed type to string * updated to null * introduced indentation * updated spec * updated spec to have include_all false as default * updated type from bool to boolean

This reverts commit a6777ed.

* updated port name * added a space * updated message

* updated message * updated message * updated message * updated message * updated message * updated message * updated message * updated message * updated to use s3 as default support for lambda * removed release

* updated repository url * updated repository url * updated repository url * updated repository url * updated repository url * updated repository url * updated the order for helm spec

* add s3 lifecycle rules * sns updates * no need of pattern here * add titles to s3 yaml

* added the terraform module * updates to facets.yaml * terraform fmt * added outputs

* Added artifactories facets modules * added schema * updated spec * changed type to string * updated to null * introduced indentation * updated spec * updated spec to have include_all false as default * updated type from bool to boolean * added intent level output

* added artifactories module * updates to vault module * removed facets yaml outputs * added gitignore files * Cleaned up ignored files * Cleaned up ignored files * Cleaned up ignored files * added artifactories module * updated to vault facets.yaml * terraform fmt * deleted zip_modules.py * updated module source

* added zip modules py * updated the print statement * modified the print message in zip_modules.py * Implement concurrent zipping and uploading to S3 in zip_modules.py * Update publish workflow to run on custom runner and assume dependencies are installed. * Move zip_modules.py to workflows folder. * removed comments * added support for optional variable branch * Add dependency installation step to publish workflow. * added support for optional variable branch * added support for install dependencies * Add S3 bucket name to zip_modules.py. * updated workflow and create a new directory to zip modules * updated workflow and create a new directory to zip modules * updated workflow and create a new directory to zip modules * Update requirements.txt to include only necessary external dependencies. * posting success message to slack channel * removed the development branch support * changes * changes * deleted zip modules previous file * Update publish workflow to use S3_BUCKET_NAME from workflow variable. * Update zip_modules.py to use S3 bucket name from environment variable.

* add aider to gitignore * a new external module * move to version folder * feat: Implement external PostgreSQL module with interfaces output structure * feat: Enhance facets.yaml with titles and UI overrides for properties * feat: Update module to use standard outputs and instance spec structure * fix: Correct YAML formatting in facets.yaml for sample spec section * implementation of an external postgres * ui fixes --------- Co-authored-by: rohit <[email protected]>

* Updated preview.yml to read token secret name from TokenRef * Updated preview.yml to read token secret name from TokenRef * Updated preview.yml to append -github_ref to the version in facets.yaml

* fix for reading secret * fix for reading secret * updated to single quotes * updated the logic of reading the control planes json * updated the logic of creating the control planes json * Updated preview.yml to work with control_planes.json * Updated preview.yml to use format function for dynamic token retrieval * added TOKEN_REF_NAME * update to get the module directory path * using all secrets * added a cat command * updated the jq commands * updating the sample version as well * updating the sample version as well * updated the script to fail if any command failed * testing fail scenario * Revert "testing fail scenario" This reverts commit 0d25918. * added a few assertions * updated the variables name

add kubernetes cluster output in intent

* added 0.2 mongo_user module * added the mongo_user 0.2 module * added mongo user entry in index.json * version fix for mongo_user 0.2 * added kubernets display name * updated the display name of user inputs for db users

* added github workflows for validate bootrapper * added step for trigger validate-bootstrapper in publish.yml * changed the trigger name * using workflow_runs

Co-authored-by: Himanshu Mahto <[email protected]>

…cets.yaml

ishaankalra · 2025-02-26T06:38:55Z

Please rebase this

RoguedBear · 2025-02-26T09:32:38Z

didn't get time @ishaankalra, thats why I've kept it in draft. I'll rebase and mark ready for review soon

coderabbitai · 2025-06-18T04:12:55Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Shashwatpathak05 and others added 30 commits January 17, 2025 16:15

if price is 0, exclude from dataset (#174)

fe043d9

* if price is 0, exclude from dataset * removed .DS_Store * added generated files

removed incorrect files (#176)

bc2f785

update gitref for sqs

80d1608

add gitref for sns

bed4978

Revert "add gitref for sns"

49d0b4d

This reverts commit d95ff4a03b0c9af774836205222e5a7f80b3610f.

Revert "update gitref for sqs"

bc27ae2

This reverts commit 06034ac40e84b1b19cf139c597953309ad694a7e.

Alb aws facets yaml (#208)

8b4059d

* upadted facets-module * upadted facets-module * updated overrides for domains * updated overrides for domains * updated port name * updated port name

add output for custom iam policy (#212)

fdb3960

Fix mismatches in sample for flavor version (#211)

4ab18e9

* Fix mismatches in sample jsons * Remove unintended change

Revert "[S73] Feature: Per-Instance Artifactories Module (#210)" (#214)

4cc7ce2

This reverts commit a6777ed.

Updated azure roles regex (#217)

961abb1

* updated port name * added a space * updated message

Aws lambda (#218)

7deb484

* updated message * updated message * updated message * updated message * updated message * updated message * updated message * updated message * updated to use s3 as default support for lambda * removed release

if price is 0, exclude from dataset (#174)

ea8a12d

* if price is 0, exclude from dataset * removed .DS_Store * added generated files

removed incorrect files (#176)

8791340

update gitref for sqs

728cba9

add gitref for sns

b9eee37

Revert "add gitref for sns"

49deaf8

This reverts commit d95ff4a03b0c9af774836205222e5a7f80b3610f.

Revert "update gitref for sqs"

7239881

This reverts commit 06034ac40e84b1b19cf139c597953309ad694a7e.

Revert "[S73] Feature: Per-Instance Artifactories Module (#210)" (#214)

aaa659f

This reverts commit a6777ed.

Updated azure roles regex (#217)

83a1fdc

* updated port name * added a space * updated message

Aws lambda (#218)

963df6b

* updated message * updated message * updated message * updated message * updated message * updated message * updated message * updated message * updated to use s3 as default support for lambda * removed release

feat: Add ecs_service intent for managing containers in Amazon ECS

602ecbd

Helm repo pattern fix (#220)

58c82ac

* updated repository url * updated repository url * updated repository url * updated repository url * updated repository url * updated repository url * updated the order for helm spec

s3 lifecycle rules and sns s3 trigger filter (#221)

d9b69ba

* add s3 lifecycle rules * sns updates * no need of pattern here * add titles to s3 yaml

update disruption options visibility (#223)

947f6ab

Vault Terraform module (#227)

7b81ecc

* added the terraform module * updates to facets.yaml * terraform fmt * added outputs

ishaankalra and others added 18 commits February 6, 2025 12:06

Preview modules (#239)

aff5a60

* Updated preview.yml to read token secret name from TokenRef * Updated preview.yml to read token secret name from TokenRef * Updated preview.yml to append -github_ref to the version in facets.yaml

simplisamrt fixes

d3c6b39

simplismart helm fix

35109f8

moving _ before - which causes issues

ea76ed6

add kubernetes cluster output in intent

3e33a56

resolved conflicts

b3e8be7

Merge pull request #244 from Facets-cloud/kubernetes-output

8750e0c

add kubernetes cluster output in intent

updated echo messages

7dd9cab

Input output modelling part 1 (#233)

bff0c74

* added 0.2 mongo_user module * added the mongo_user 0.2 module * added mongo user entry in index.json * version fix for mongo_user 0.2 * added kubernets display name * updated the display name of user inputs for db users

added github workflows for validate bootrapper (#245)

d8ec748

Validate bootstraper (#246)

f0405b7

* added github workflows for validate bootrapper * added step for trigger validate-bootstrapper in publish.yml * changed the trigger name * using workflow_runs

using workflow_runs conclusion

bd4fb10

updated validate-bootstrapper.yml message

5aa95a5

Added new icons for the intents (#240)

44f09e4

Co-authored-by: Himanshu Mahto <[email protected]>

Add Azure Service Bus facets yaml and output type

65acacb

RoguedBear added the blocked label Feb 7, 2025

RoguedBear added 2 commits February 7, 2025 16:45

chore(azure_service_bus): mark default for disabled as true

47873d9

feat(azure_service_bus): add subscription configuration options in fa…

b6e54ad

…cets.yaml

pramodh-ayyappan force-pushed the develop branch from dfa93f0 to 32fb2f4 Compare February 11, 2025 11:43

RoguedBear mentioned this pull request Feb 17, 2025

Add outputs facets.yaml for AWS, Azure, and GCP VPCs #263

Merged

8 tasks

pramodh-ayyappan force-pushed the develop branch 2 times, most recently from 2c29f43 to a2321a4 Compare March 12, 2025 06:50

Base automatically changed from develop to master March 12, 2025 07:03

rr0hit force-pushed the azure-svc-bus branch from 16c6d8e to b6e54ad Compare June 18, 2025 04:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Azure Service Bus facets yaml and output type #248

Add Azure Service Bus facets yaml and output type #248

Uh oh!

RoguedBear commented Feb 7, 2025 •

edited

Loading

Uh oh!

ishaankalra commented Feb 26, 2025

Uh oh!

RoguedBear commented Feb 26, 2025

Uh oh!

coderabbitai bot commented Jun 18, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Add Azure Service Bus facets yaml and output type #248

Are you sure you want to change the base?

Add Azure Service Bus facets yaml and output type #248

Uh oh!

Conversation

RoguedBear commented Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Type of change

Checklist

Testing

Reviewer instructions

Uh oh!

ishaankalra commented Feb 26, 2025

Uh oh!

RoguedBear commented Feb 26, 2025

Uh oh!

coderabbitai bot commented Jun 18, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

RoguedBear commented Feb 7, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)