Skip to content

queueExecuteAndWrapIotas: allow specifying continuation #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
object-Object merged 2 commits into from
Nov 18, 2025
Merged

queueExecuteAndWrapIotas: allow specifying continuation #965

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93b1c40
queueExecuteAndWrapIotas: allow specifying continuation
PoolloverNathan Nov 18, 2025
4fd9ca4
premature optimization
PoolloverNathan Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Common/src/main/java/at/petrak/hexcasting/api/casting/eval/vm/CastingVM.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,11 @@ class CastingVM(var image: CastingImage, val env: CastingEnvironment) {
*
* Mutates this
*/
fun queueExecuteAndWrapIotas(iotas: List<Iota>, world: ServerLevel): ExecutionClientView {
@JvmOverloads
fun queueExecuteAndWrapIotas(iotas: List<Iota>, world: ServerLevel, nextContinuation: SpellContinuation = SpellContinuation.Done): ExecutionClientView {
// Initialize the continuation stack to a single top-level eval for all iotas.
var continuation = SpellContinuation.Done.pushFrame(FrameEvaluate(SpellList.LList(0, iotas), false))
// HACK: Ideally, we'd have a separate (SpellContinuation, ServerWorld) overload, but then 0.11.3 would cause mixins to break. Look into properly splitting this in 1.21?
Comment on lines -43 to +44
Copy link
Member

@object-Object object-Object Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you open an issue to track this?

Copy link
Contributor Author

@PoolloverNathan PoolloverNathan Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, what should it look like (or do you have examples)? not exactly sure what the issue conventions are

Copy link
Member

@object-Object object-Object Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something along the lines of #926 would be fine. Just a reminder to clean up the code the next time we can make a breaking change.

var continuation = if (iotas.isNotEmpty()) nextContinuation.pushFrame(FrameEvaluate(SpellList.LList(0, iotas), false)) else nextContinuation;
// Begin aggregating info
val info = TempControllerInfo(earlyExit = false)
var lastResolutionType = ResolvedPatternType.UNRESOLVED
Expand Down
Loading