queueExecuteAndWrapIotas: allow specifying continuation #965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a defaulted queueExecuteAndWrapIotas() parameter to allow specifying the continuation (in addition to the generated FrameEvaluate frame). This should not change current behavior, and, due to @jvmoverloads, does not break compatibility with existing addons.
PoolloverNathan
force-pushed
the
continuation-overload
branch
from
bfd1119 to
93b1c40
Compare
PoolloverNathan
force-pushed
the
continuation-overload
branch
from
f0c4d14 to
4fd9ca4
Compare
Comment on lines
-43
to
+44
| var continuation = SpellContinuation.Done.pushFrame(FrameEvaluate(SpellList.LList(0, iotas), false)) | ||
| // HACK: Ideally, we'd have a separate (SpellContinuation, ServerWorld) overload, but then 0.11.3 would cause mixins to break. Look into properly splitting this in 1.21? |
Member
There was a problem hiding this comment.
Can you open an issue to track this?
Contributor
Author
There was a problem hiding this comment.
sure, what should it look like (or do you have examples)? not exactly sure what the issue conventions are
Member
There was a problem hiding this comment.
Something along the lines of #926 would be fine. Just a reminder to clean up the code the next time we can make a breaking change.
Contributor
Author
|
seems to break hexxyinthealps and all mods that inject into this method weirdly, https://mclo.gs/rn9Glcl |
object-Object
added a commit
that referenced
this pull request
Nov 20, 2025
…" (fix #967) This reverts commit c64e5d7, reversing changes made to 22b7a6f. The changes made in #965 were meant to avoid any impact for addons, but we've since realized that adding an optional argument to a method still breaks mixins targeting that method. This caused a crash with HexxyInTheAlps and may also break other addons. While mixin impacts aren't technically breaking changes, we still don't really want to break an unknown number of addons this close to a release, so we'll resolve this issue by reverting #965 and revisiting this change at a later date.
Merged
PoolloverNathan
pushed a commit
to PoolloverNathan/HexMod
that referenced
this pull request
Nov 20, 2025
PoolloverNathan
added a commit
to PoolloverNathan/HexMod
that referenced
this pull request
Nov 20, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a defaulted queueExecuteAndWrapIotas() parameter to allow specifying the continuation (in addition to the generated
FrameEvaluateframe). This should not change current behavior, and, due to@JvmOverloads, does not break compatibility with existing addons.