Open
Conversation
ArthurKun21
force-pushed
the
fix-script-manager-linter
branch
from
5789aca to
f7abf19
Compare
ArthurKun21
force-pushed
the
fix-script-manager-linter
branch
from
f7abf19 to
27a9136
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes linter issues by updating localized string resources and cleaning up unnecessary lint suppression in ScriptManager.
- Updated Korean and Japanese localized strings for "picked_exp_stacks" by adding a second format placeholder.
- Removed a suppression annotation (and its TODO comment) from ScriptManager.kt.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/src/main/res/values-ko/localized.xml | Updated Korean string for "picked_exp_stacks" to include an additional placeholder. |
| app/src/main/res/values-ja/localized.xml | Updated Japanese string for "picked_exp_stacks" with an added placeholder. |
| app/src/main/java/io/github/fate_grand_automata/runner/ScriptManager.kt | Removed redundant SuppressLint annotation and outdated TODO comment. |
Comments suppressed due to low confidence (3)
app/src/main/java/io/github/fate_grand_automata/runner/ScriptManager.kt:104
- [nitpick] Since the suppression annotation has been removed, consider removing or updating the TODO comment to avoid confusion.
// TODO remove suppression when AutoGiftBox exit message is localized
app/src/main/res/values-ko/localized.xml:262
- Verify that all call sites supplying values for 'picked_exp_stacks' now provide two parameters to prevent runtime format exceptions.
<string name="picked_exp_stacks">"%1$d을 선택하고 %2$d를 받았습니다."</string>
app/src/main/res/values-ja/localized.xml:271
- Verify that all consumers of 'picked_exp_stacks' in Japanese are updated to supply two formatting parameters to avoid runtime issues.
<string name="picked_exp_stacks">"%1$d個を選択し、%2$d個の残り火を受け取りました。"</string>
ArthurKun21
force-pushed
the
fix-script-manager-linter
branch
from
27a9136 to
2f58b36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Script Manager linter
Pull Request Type
Related issue
Description
Used MTL to fix the linter problem.
Screenshots
Testing
Additional context