Skip to content

Fix Script Manager linter #1932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArthurKun21 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Script Manager linter #1932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions app/src/main/java/io/github/fate_grand_automata/runner/ScriptManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package io.github.fate_grand_automata.runner

import android.annotation.SuppressLint
import android.app.Service
import android.content.ClipboardManager
import android.content.Context
Expand Down Expand Up @@ -103,8 +102,6 @@ class ScriptManager @Inject constructor(
}
}

// TODO remove suppression when AutoGiftBox exit message is localized
@SuppressLint("StringFormatMatches")
private fun onScriptExit(e: Exception) = scope.launch {
uiStateHolder.uiState = ScriptRunnerUIState.Idle
uiStateHolder.isPlayButtonEnabled = false
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/values-ja/localized.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@
<string name="turns_stats">"ターン数: %1$d (最小), %2$.02f (平均), %3$d (最大)"</string>

<!-- Fuzzy -->
<string name="picked_exp_stacks">%1$d 個の種火を選び受け取りました。</string>
<string name="picked_exp_stacks">"%1$d個を選択し、%2$d個の残り火を受け取りました。"</string>
<string name="no_embers_found">"画面上に「種火」が見つかりません。サーヴァント(経験値)のフィルタリングを確認してください。"</string>
<string name="root_failed">"ルート権限の取得に失敗"</string>
<string name="p_mats">"素材"</string>
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/values-ko/localized.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@
<string name="turns_stats">"턴: %1$d (최단), %2$.02f (평균), %3$d (최장)"</string>

<!-- Fuzzy -->
<string name="picked_exp_stacks">%1$d개의 종화 묶음 획득</string>
<string name="picked_exp_stacks">"%1$d을 선택하고 %2$d를 받았습니다."</string>
<string name="no_embers_found">"화면에서 종화를 찾을 수 없습니다. 종화를 필터하지 않았는지 확인바랍니다."</string>
<string name="root_failed">"루트 권한을 얻는데 실패했습니다."</string>
<string name="p_mats">"재료"</string>
Expand Down