Fix: update Na and Tw to new face card region#2201
Merged
Conversation
3 tasks
vybze
changed the title
ArthurKun21
reviewed
Mar 24, 2026
| val servantDetailsFaceCardRegion = when (gameServer) { | ||
| // FGO JP 2024-04-12 updated the UI resulting in the bricking of the face card detection | ||
| is GameServer.Jp, GameServer.Cn, is GameServer.Kr -> Region(-685, 410, 110, 60).xFromCenter() | ||
| is GameServer.Jp, GameServer.Cn, is GameServer.Kr, is GameServer.En -> Region(-685, 410, 110, 60).xFromCenter() |
Collaborator
There was a problem hiding this comment.
Switch to Tw only here and move the comment to else
Collaborator
Author
|
It's been reported that Tw has gotten the same update too |
vybze
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update face check Region for na